299449 - File res/hiddenWindow.html missing in installer build

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Michael Taeuber]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.9) Gecko/20050702 Firefox/1.0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.7.9) Gecko/20050702 Firefox/1.0.5

When using the installer build (exe-file) of the nightly
2005-07-02-04-aviary1.0.1 , Firefox doesn't start up. There is an error message
that the file res/hiddenWindow.html is missing.
After creating an empty file with this name, Firefox starts.
The missing file is included in the zip build.

Reproducible: Always

Steps to Reproduce:
1. Install Firefox 2005-07-02 using the installer build
2. Try to start Firefox
3.

Actual Results:  
Firefox doesn't start. Error message about missing file res/hiddenWindow.html
shows up.

Expected Results:  
Firefox should start :-)

Comment 1

[Ria Klaassen (not reading all bugmail)]

Thanks! :)

Comment 2

[Benjamin Smedberg]

Fixed on trunk by my own authority, thanks for the quick and accurate bugreport!

Comment 3

[Benjamin Smedberg]

This needs to be fixed on the branches, and it doesn't have a 1.7.x blocking
flag, bah.

Comment 4

[Bernard Alleysson]

*** Bug 299451 has been marked as a duplicate of this bug. ***

Comment 5

[Timothy B. Anderson (Tails)]

This bug is also in the Mozilla nightly for 2005070205 but, it seems to be
running fine after clicking OK.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

bug 299463 is the seamonkey version

Comment 7

[Michael Taeuber]

Problem exists also in Thunderbird nightly 2005-07-02-07-aviary1.0.1, but T-Bird
doesn't show a error message.
Is this problem also solved by the fix of Benjamin Smedberg?

Comment 8

[doctor__j]

*** Bug 299477 has been marked as a duplicate of this bug. ***

Comment 9

[Benjamin Smedberg]

*** Bug 299503 has been marked as a duplicate of this bug. ***

Comment 10

[Benjamin Smedberg]

*** Bug 299523 has been marked as a duplicate of this bug. ***

Comment 11

[Jacek Piskozub]

(In reply to comment #3)
> This needs to be fixed on the branches, and it doesn't have a 1.7.x blocking
> flag, bah.

The suite trunk and 1.7 branch have been covered by bug 299463.

Comment 12

[Jay Patel [:jay]]

CC'ing jst, this looks like a regression from his recent checkin for bug 297543.

Benjamin: Please get this fix on the Aviary 1.0.1 branch asap!  a=jay

Comment 13

[Teune van Steeg]

On linux trunk this still isn't fixed; in the fix Benjamin landed by comment #2
hiddenWindow.css is added instead of hiddenWindow.html.
http://lxr.mozilla.org/mozilla/source/browser/installer/unix/packages-static#230

Can somebody reopen this bug?

Comment 14

[Teune van Steeg]

Attachment: patch to correct things on linux

Comment 15

[:Gavin Sharp [email: [e-mail]]]

For reference, the Benjamin's checkin was:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&filetype=match&who=bsmedberg%25covad.net&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-07-02+06%3A19&maxdate=2005-07-02+06%3A19&cvsroot=%2Fcvsroot

Comment 16

[Tracy Walker [:tracy]]

fyi: 'tis a smoketest blocker Win 2005-07-05-04-aviary1.0.1

Comment 17

[Benjamin Smedberg]

Committed unix s/css/html/ and committed on AVIARY_1_0_1_20050124_BRANCH.

Comment 18

[Myk Melez [:myk] [@mykmelez]]

*** Bug 299772 has been marked as a duplicate of this bug. ***

Comment 19

[Joe Drew (not getting mail)]

The Linux fix doesn't seem to be checked in on the trunk, and I'm seeing the
problem even on non-installer builds. (i.e., latest nightly needs me to touch
res/hiddenWindow.html.)

Comment 20

[Jacek Piskozub]

Joe, is your build GRE based? If so, it may be the same problem as in Windows
(see bug 299463) where the hiddenWindow.html was missing in GRE creating the
very same problem. The reason is the patch from the secret bug patch from the
secret bug 297543 changed mozilla/xpfe/appshell/src/nsAppShellService.cpp replacing
"about:blank" with "resource://gre/res/hiddenWindow.html". Take note there is a
"gre" in the URI.

Comment 21

[Joe Drew (not getting mail)]

Jacek, it looks like my build is gre-based. I'm not positive - all I did was
download the nightly build - but my firefox directory contains the subdirectory
"greprefs," and the resource URL you quoted works, while without "gre" it
doesn't work at all.

Comment 22

[Tracy Walker [:tracy]]

verified fixed on Fx branch with Windows and Linux builds from 0706

Comment 23

[Nick Johnston]

Still broken on Seamonkey Win32 build 2005070605 on WinXP. 

Comment 24

[Tracy Walker [:tracy]]

This is also on Windows Thunderbird 1.0.5 2005-07-06-07-aviary1.0.1
as a workaround I cut and pasted hiddenWindow.html from Fx 1.0.5 to /res

Comment 25

[Tracy Walker [:tracy]]

ignore my last comment #24, I had inadvertently installed yesterdays build. 
this is fixed in Windows Tbird build 2005-07-06-07-aviary1.0.1

Comment 26

[Zibi Braniecki [:zbraniecki][:gandalf]]

*** Bug 299714 has been marked as a duplicate of this bug. ***

Comment 27

[Ryan Hill]

*** Bug 299584 has been marked as a duplicate of this bug. ***

Comment 28

[Andrew Schultz]

isn't this fixed?

Comment 29

[Daniel Schroeter]

I don't know the version of Bugzilla on this site, but maybe someone changed the
flag with this Bugzilla bug:
http://www.bugzilla.org/security/2.18.1/

Comment 30

[Darin Grimm]

Shouldn't this bug be marked fixed? -- trying to clean up the "regression" list