Closed
Bug 299851
Opened 19 years ago
Closed 19 years ago
nsIAboutModule documentation outdated?
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
VERIFIED
FIXED
mozilla1.8beta4
People
(Reporter: Biesinger, Assigned: jklippel)
References
()
Details
Attachments
(1 file)
1.29 KB,
patch
|
darin.moz
:
review+
bzbarsky
:
superreview+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
52 * @param originalURI - Specifies the original URI which caused the creation [...] 59 nsIChannel newChannel(in nsIURI aURI); There does not seem to be an originalURI parameter...
Reporter | ||
Updated•19 years ago
|
Whiteboard: [good first bug]
Updated•19 years ago
|
Keywords: helpwanted
Target Milestone: --- → Future
Assignee | ||
Comment 1•19 years ago
|
||
nsIURI* originalURI was introduced to the interface in nsIAboutModule.idl rev. 1.4 and nsAboutProtocolHandler.cpp rev. 1.6 because of bug 17144. It was removed from nsIAboutModule.idl rev. 1.9 on 2000-03-28 due to "Necko API changes..." (see cvs log). The Necko API changes removed the parameter from nsIProtocolHandler.idl::newChannel(...). I can't figure out any use for the parameter in nsIAboutProtocolHandler.cpp back then (it's probably just been there to stick to the inherited interface). (IMHO) But that's history. Looking at the nsAboutProtocolHandler::NewChannel current method even the part of the comment saying that if null the aURI parameter will be used is invalid with the current interface. So I suggest removing the @param originalURI description completely.
Assignee | ||
Comment 2•19 years ago
|
||
patch to adjust comment
Attachment #188846 -
Flags: review?(darin)
Updated•19 years ago
|
Attachment #188846 -
Flags: review?(darin) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #188846 -
Flags: superreview?(bzbarsky)
Comment 3•19 years ago
|
||
Comment on attachment 188846 [details] [diff] [review] patch to adjust comment Let me know once this has approvals if you want me to check it in, ok?
Attachment #188846 -
Flags: superreview?(bzbarsky) → superreview+
Updated•19 years ago
|
Attachment #188846 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #188846 -
Flags: approval1.8b4? → approval1.8b4+
Updated•19 years ago
|
Assignee: darin → jklippel
Comment 4•19 years ago
|
||
Checked in for 1.8b4. Thanks for the patch!
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: Future → mozilla1.8beta4
V/fixed: 1.13 bzbarsky%mit.edu 2005-07-15 14:49 Update documentation. Bug 299851, patch by J.P.Klippel <jklippel@xtux.org>, r=darin, sr=bzbarsky, a=bsmedberg
You need to log in
before you can comment on or make changes to this bug.
Description
•