299873 - javascript error "strings has no properties" when opening help menu in bookmark manager

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Opening the help menu of the bookmark manager following js error is thrown:

Error: strings has no properties
Source File: chrome://browser/content/utilityOverlay.js
Line: 430

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: patch adds missed stringbundleset to bookmarksManager.xul

Comment 2

[:Gavin Sharp [email: [e-mail]]]

The stringbundle should be added at
http://lxr.mozilla.org/mozilla/source/browser/base/content/baseMenuOverlay.xul#130
, otherwise it won't work on Mac or in the DOM Inspector.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 188466 [details] [diff] [review]
patch adds missed stringbundleset to bookmarksManager.xul

comment 1 is right, minusing.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: patch added the stringbundle to baseMenuOverlay.xul

Thank you Gavin. I didn't saw it on my Linux build. DOMi was just working
correctly but I don't have a Mac.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: patch added the stringbundle to baseMenuOverlay.xul

Thank you Gavin. I didn't saw it on my Linux build. DOMi was just working
correctly but I don't have a Mac.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Fix checked in.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch removes bundle_browser in browser-sets.inc

The bundle was already defined in browser-sets.inc which is also included by
browser.xul. We have to remove it there.

Comment 8

[Asaf Romano (gone)]

Checking in browser-sets.inc;
/cvsroot/mozilla/browser/base/content/browser-sets.inc,v  <--  browser-sets.inc
new revision: 1.50; previous revision: 1.49
done