300001 - JS errors and strict warnings in dialog "Download actions"

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

The dialog for viewing and editing download actions within the preferences has
several js errors and warnings. It's really simple to replicate.

1. Open the dialog
2. Enter a search term
3. Double click somewhere inside the tree.

Because a non-existing entry is selected, following errors and warnings are shown:

Warning: reference to undefined property this.activeCollection[aIndex]
Source File: chrome://browser/content/preferences/downloadactions.js
Line: 365

Warning: trailing comma is not legal in ECMA-262 object initializers
Source File: chrome://browser/content/preferences/changeaction.js
Line: 219
Source Code:
};

Error: this._item has no properties
Source File: chrome://browser/content/preferences/changeaction.js
Line: 13

Error: item has no properties
Source File: chrome://browser/content/preferences/downloadactions.js
Line: 589


Hitting "Clear" after that, this strict warning appears:

Warning: assignment to undeclared variable i
Source File: chrome://browser/content/preferences/downloadactions.js
Line: 717

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Since bug 300074 is fixed only one strict warning is left:

Warning: assignment to undeclared variable i
Source File: chrome://browser/content/preferences/downloadactions.js
Line: 720

A patch will follow immediately.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch which removes the last strict warnings

Ok, two more warnings were left. This patch fixes them all.

Comment 3

[Karsten Düsterloh]

Checking in changeaction.js;
/cvsroot/mozilla/browser/components/preferences/changeaction.js,v  <-- 
changeaction.js
new revision: 1.3; previous revision: 1.2
done
Checking in downloadactions.js;
/cvsroot/mozilla/browser/components/preferences/downloadactions.js,v  <-- 
downloadactions.js
new revision: 1.5; previous revision: 1.4
done