Closed
Bug 300149
Opened 19 years ago
Closed 19 years ago
[SM v1.0a++, Windows] In "Add/Remove Programs", version is "1.0" instead of "1.0a"
Categories
(SeaMonkey :: Installer, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey1.0alpha
People
(Reporter: sgautherie, Assigned: Biesinger)
Details
Attachments
(1 file)
911 bytes,
patch
|
benjamin
:
review+
dveditz
:
superreview+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b3) Gecko/20050708 SeaMonkey/1.0a] (nightly) (W98SE) In "Add/Remove Programs", program name was rebranded from "Mozilla (1.8b2)", which was fine to "SeaMonkey (1.0)", which is out of sync.. This is misleading, and, if it works as "Mozilla" was, will prevent installing v1.0a along v1.0b along v1.0(f) :-(
Reporter | ||
Updated•19 years ago
|
Flags: blocking-seamonkey1.0a?
Comment 1•19 years ago
|
||
In a recent creature build log, I see the following messages that could be related: make: Entering directory `/cygdrive/c/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpinstall/packager' make -C windows installer make[1]: Entering directory `/cygdrive/c/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpinstall/packager/windows' /cygdrive/c/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/build/cygwin-wrapper /cygdrive/c/Perl/bin//perl /cygdrive/c/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpinstall/packager/windows/makeall.pl -aurl http://ftp.mozilla.org/pub/mozilla.org/seamonkey/nightly/2005-07-16-07-trunk/windows-xpi -objdir c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla \ -instname seamonkey-1.0a.en-US.win32.installer -stubname seamonkey-1.0a.en-US.win32.stub-installer Building SeaMonkey Raw version id : 1.0.0.2005071606 Display version : 1.0 Xpinstall version: 1.0.0.2005071606 Building GRE Raw version id : 1.0.0.2005071606 Display version : 1.0 Xpinstall version: 1.0.0.2005071606 and a bit later, after GRE stuff: Building SeaMonkey 1.0 (en)... Might the issue be caused along those lines? Note that we did some changes to module.ver with the rebranding stuff, I don't know if that can be releated...
Reporter | ||
Comment 2•19 years ago
|
||
(In reply to comment #1) I compared http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1121524320.22043.gz (WINNT 5.0 creature Clobber on 07/16 07:32:00) to http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1119482280.19959.gz (WINNT 5.0 creature Clobber on 06/22 16:18:00) [randomly found] > /cygdrive/c/Perl/bin//perl (nit: why '//'...) > Building SeaMonkey > Raw version id : 1.0.0.2005071606 > Display version : 1.0 > Xpinstall version: 1.0.0.2005071606 > > > Building GRE > Raw version id : 1.0.0.2005071606 > Display version : 1.0 > Xpinstall version: 1.0.0.2005071606 Building Mozilla Raw version id : 1.8b2.0.2005062216 Display version : 1.8b2 Xpinstall version: 1.8.0.2005062216 Building GRE Raw version id : 1.8b2.0.2005062216 Display version : 1.8b2 Xpinstall version: 1.8.0.2005062216 We miss the 'a' on the two first lines. > and a bit later, after GRE stuff: > > Building SeaMonkey 1.0 (en)... Building Mozilla 1.8b2 (en)... We miss the 'a'. (I don't know more about this.)
Assignee | ||
Comment 3•19 years ago
|
||
this should do it. kairo: note that this would not have been an issue had version.txt a new line at the end :-) this doesn't fix the version number in the first wizard page, but afaict nonnumeric characters are forcefully removed there.
Assignee: general → cbiesinger
Status: NEW → ASSIGNED
Attachment #189975 -
Flags: superreview?(dveditz)
Attachment #189975 -
Flags: review?(benjamin)
Assignee | ||
Updated•19 years ago
|
Priority: -- → P1
Target Milestone: --- → Seamonkey1.0alpha
Updated•19 years ago
|
Attachment #189975 -
Flags: review?(benjamin) → review+
Comment 4•19 years ago
|
||
Comment on attachment 189975 [details] [diff] [review] patch [Checked in: Comment 6] sr=dveditz This might lead to mysterious problems if someone leaves spaces on the end. Would a regexp be better?
Attachment #189975 -
Flags: superreview?(dveditz) → superreview+
Reporter | ||
Comment 5•19 years ago
|
||
Comment on attachment 189975 [details] [diff] [review] patch [Checked in: Comment 6] 'approval1.8b4=?': (SeaMonkey only) Trivial Installer code fix, no risk.
Attachment #189975 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #189975 -
Flags: approval1.8b4? → approval1.8b4+
Assignee | ||
Comment 6•19 years ago
|
||
Checking in xpinstall/packager/StageUtils.pm; /cvsroot/mozilla/xpinstall/packager/StageUtils.pm,v <-- StageUtils.pm new revision: 1.9; previous revision: 1.8 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•19 years ago
|
Attachment #189975 -
Attachment description: patch → patch
[Checked in: Comment 6]
Comment 7•19 years ago
|
||
Serge: Please, 1) do not ask for flags on patches other people are working on, that's up to them to do, 2) do not change descriptions of patches of other people (if the patch is on a FIXED bug, we know it's checked in, noone needs that in the description as well), 3) do not add cryptic strings into the bug summary, if they just tell things set better on other fields in the report (e.g. the OS and Version fields tell us enough about where this bug is happening). If you follow those pieces of advice, I think some people will be less annoyed by some of your reports. That said, thanks for working with us doing QA on SeaMonkey and helping us to ship a better apllication.
Reporter | ||
Comment 8•19 years ago
|
||
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b4) Gecko/20050729 SeaMonkey/1.0a] (nightly) (W98SE) V.Fixed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•