Closed
Bug 300226
Opened 19 years ago
Closed 19 years ago
crash on exit when using gtk 2.7
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: chpe, Assigned: chpe)
Details
(Keywords: fixed-aviary1.0.8, fixed1.7.13, fixed1.8)
Attachments
(1 file)
1011 bytes,
patch
|
mpgritti
:
review+
roc
:
superreview+
dveditz
:
approval-aviary1.0.8+
dveditz
:
approval1.7.13+
asa
:
approval1.8b4+
|
Details | Diff | Splinter Review |
Sometimes when shutting down firefox running with gtk 2.7, it crashes. Trace: #0 0xb77a561f in IA__g_type_check_instance_is_a (type_instance=0xdadadada, iface_type=135686288) at gtype.c:3127 #1 0xb7bb1481 in IA__gtk_widget_get_toplevel (widget=0x8259840) at gtkwidget.c:6037 #2 0xb7abacc2 in gtk_main_get_window_group (widget=Variable "widget" is not available.) at gtkmain.c:1462 #3 0xb7abae1f in IA__gtk_main_do_event (event=0x82d91c0) at gtkmain.c:1286 #4 0xb79451da in gdk_event_dispatch (source=0xdadadada, callback=0, user_data=0x0) at gdkevents-x11.c:2265 [...] The trace is very similar to the one from http://bugzilla.gnome.org/show_bug.cgi?id=309505 and the fix should be simple; I'm going to attach a patch.
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #188798 -
Flags: superreview?(blizzard)
Attachment #188798 -
Flags: review?(mpgritti)
Updated•19 years ago
|
Attachment #188798 -
Flags: review?(mpgritti) → review+
Assignee | ||
Comment 2•19 years ago
|
||
Comment on attachment 188798 [details] [diff] [review] unset the gdk window user data before destroying them Switching sr request to roc. I hope you don't mind :)
Attachment #188798 -
Flags: superreview?(blizzard) → superreview?(roc)
Comment 3•19 years ago
|
||
I've been having a similar stack trace from a bug (described here in bugzilla.fedora -- https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=163692), that occurs most often in dialog boxes when clicking on random button. An example: 'Bookmark this page' and when in the dialog, click on cancel, repeat 10 times, and you won't make it to 10 (or I and some others don't). It was claimed that a cairo patch fixed this but I think the patch in this bugzilla report is the answer. Have you noticed any other spurious button clicking crashes (other than the shutting down crash)? Thanks much, Mick
Attachment #188798 -
Flags: superreview?(roc) → superreview+
Assignee | ||
Comment 4•19 years ago
|
||
Comment on attachment 188798 [details] [diff] [review] unset the gdk window user data before destroying them Fixes a crash when running under gtk+ 2.7; no risk.
Attachment #188798 -
Flags: approval1.8b4?
Updated•19 years ago
|
Attachment #188798 -
Flags: approval1.8b4? → approval1.8b4+
Assignee | ||
Comment 5•19 years ago
|
||
Comment on attachment 188798 [details] [diff] [review] unset the gdk window user data before destroying them Fixes a crash with gtk+ 2.7, no risk. Since many distributions will probably ship ff 1.0.x with gtk+ 2.8 soon, should also land on branches.
Attachment #188798 -
Flags: approval1.7.12?
Attachment #188798 -
Flags: approval-aviary1.0.7?
Our dot-releases are generally for security fixes and regressions from security fixes. We've also been getting strong criticism lately from Linux distributors for taking non-security fixes in our security releases (even though that's been extremely rare in releases other than 1.7.5). So this probably doesn't meet our criteria for branches.
Comment 7•19 years ago
|
||
I disagree. The complaint is not that non-security fixes are shipped, its that the security fixes aren't pointed out individually so they can be individually patched (by vendors who can't/won't bump version numbers). Ship things like this which make sense in a release, but include a note that this was shipped, and include notes along the lines of "these security bugs were fixed, here are patches. Use these patches if you just want security fixes. If you want the other fixes, get the full release".
Comment 8•19 years ago
|
||
just for completeness: the patch has already been checked in for trunk/1.8. And I would vote for adding it also in the older branches because there is still no newer released firefox/mozilla. So the patch would be needed for current distributions anyway. I agree with caillon here.
Comment 9•19 years ago
|
||
Fixed on trunk...
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 10•19 years ago
|
||
Comment on attachment 188798 [details] [diff] [review] unset the gdk window user data before destroying them a=dveditz for drivers
Attachment #188798 -
Flags: approval1.7.13?
Attachment #188798 -
Flags: approval1.7.13+
Attachment #188798 -
Flags: approval-aviary1.0.8?
Attachment #188798 -
Flags: approval-aviary1.0.8+
Updated•19 years ago
|
Flags: blocking1.7.13+
Flags: blocking-aviary1.0.8+
Updated•19 years ago
|
Keywords: fixed-aviary1.0.8,
fixed1.7.13
Comment 11•19 years ago
|
||
Comment on attachment 188798 [details] [diff] [review] unset the gdk window user data before destroying them mozilla/widget/src/gtk2/mozdrawingarea.c 1.9.84.1 MOZILLA_1_7_BRANCH mozilla/widget/src/gtk2/mozdrawingarea.c 1.9.98.1 AVIARY_1_0_1_20050124_BRANCH
You need to log in
before you can comment on or make changes to this bug.
Description
•