300852 - addEventListener throws an exception with FF 1.0.5

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Georges-Etienne Legendre]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5

With Firefox 1.0.5, the addEventListener throws an Exception for an element that
is in the chrome.

This is what I do :
*****
var sb = document.getElementById("searchbar");
sb.addEventListener("input", function() { alert('it works'); }, false, true);	
*****

This code throws this exception :
*****
Error: [Exception... "'JavaScript component threw a null value as an exception'
when calling method: [nsIDOMEventListener::handleEvent]" nsresult: "0x8057001d
(NS_ERROR_XPC_JS_THREW_NULL)"  location: "<unknown>"  data: no]
*****

I have to use XPCNativeWrapper to make it works. But this causes me many others
problems.
*****
var sb = new XPCNativeWrapper(document.getElementById("searchbar"),
"addEventListener()");
*****

With Firefox 1.0.4, everything was fine.

Reproducible: Always

Actual Results:  
The event listener isn't added.

Expected Results:  
No exception, and the event listener is added.

Comment 1

[[e-mail]]

Out of interest, does it work if you use this:
var sb = document.getElementById("searchbar");
sb.addEventListener("input", { handleEvent: function() { alert('it works'); } },
false, true);	

Comment 2

[Johnny Stenback (:jst)]

Can you please attach a testcase that shows this problem?

Comment 3

[Johnny Stenback (:jst)]

Found the problem, no need for a testcase.

Comment 4

[Johnny Stenback (:jst)]

Attachment: Fix.

This was due to a difference in the nsXULElement code on the trunk and
branches. On the trunk, where the patch that introduced this was developed,
nsXULElement inherits nsGenericElement and gets a QI that returns an interface
for nsIDOMNSEventTarget, but on the trunk there's no such inheritance, so
nsXULElement's QI needs to deal. This is a trivial fix to simply add the
missing code.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 189458 [details] [diff] [review]
Fix.

r+sr=bzbarsky; requesting branch approvals (this is not needed on trunk)

Comment 6

[Georges-Etienne Legendre]

Do you know if there is a work around for this problem in FF 1.0.5?

Comment 7

[Boris Zbarsky [:bzbarsky]]

You can add an event handler that listens for all events and explicitly check
the trusted flag on them...

Comment 8

[Chase Phillips]

Comment on attachment 189458 [details] [diff] [review]
Fix.

a=chase.  API fix, needs to land soon to catch respins.

Comment 9

[Johnny Stenback (:jst)]

Fixed on branches, not a problem on the trunk.