301446 - Changing several bugs at once crashes if the user wants to automatically redisplay the bug he changed

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

If the preference is set to automatically redisplay the bug the user has
changed, changing several bugs at once makes Bugzilla to crash, because more
than one bug is concerned and Bugzilla doesn't know which bug to redisplay:

invalid number of arguments (0)() at Bugzilla/Bug.pm line 122
	Bugzilla::Bug::new('Bugzilla::Bug', 1) called at
/var/www/html/cvsbugzilla/process_bug.cgi line 1852


The corresponding line in process_bug.cgi is:

} elsif ($action eq 'same_bug') {
    my $bug = new Bugzilla::Bug($cgi->param('id'), $whoid);

The problem is that $cgi->param('id') is undefined when changing several bugs at
once.

Comment 1

[:glob ✱]

Attachment: v1

Comment 2

[Frédéric Buclin]

Comment on attachment 189895 [details] [diff] [review]
v1


>+if (scalar @idlist == 1) {
>+    $action = Bugzilla->user->settings->{'post_bug_submit_action'}->{'value'};
>+} else {
>+    $action = 'nothing';
>+}

If you click "Change several bugs at once" but select only one bug, @idlist
contains only one element but $cgi->param('id') remains undefined and Bugzilla
still crashes.

What you have to test is (defined $cgi->param('id')).

Comment 3

[Frédéric Buclin]

glob, ping?

Could you please update your patch? The modification is trivial. This would
avoid us to crash everytime we change several bugs at once. :(

Comment 4

[:glob ✱]

Attachment: v2

oops, sorry lpsolit; things are pretty insane for me currently.

Comment 5

[Frédéric Buclin]

Comment on attachment 190652 [details] [diff] [review]
v2

I'm surprised that the "Bug processed" page displays "No search results
available" despite of we just edited a bug list! But that's another bug.

r=LpSolit

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Seems like we should do something more than nothing in this situation, but in
the meantime we certainly shouldn't crash.

Comment 7

[Frédéric Buclin]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.269; previous revision: 1.268
done