Closed
Bug 301811
Opened 19 years ago
Closed 19 years ago
Top link to show next page of comments not usable
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.0
People
(Reporter: Mook, Assigned: Bugzilla-alanjstrBugs)
References
()
Details
Attachments
(2 files)
832 bytes,
patch
|
csthomas
:
first-review+
|
Details | Diff | Splinter Review |
812 bytes,
patch
|
csthomas
:
first-review+
|
Details | Diff | Splinter Review |
The top "Next »" link in the all comments view is not usable; it is missing a "&id=" in the URL, so the id is never transmitted (and a gigantic numpg is used). The bottom link appears to be fine. (Originally used FlashGot as an example, but mao was complaining that everyone used his extension as a sample :p Price of popularity...)
Oddly enough, the one at the bottom has it right. Hooray for reused code.
Possible patch - since I'm not running UMO, I can't exactly test ;) This (hopefully) makes the top link the same as the bottom link. Since I'm just randomly locating stuff via LXR, this may be incorrect.
Attachment #191082 -
Flags: first-review?(Bugzilla-alanjstrBugs)
Attachment #191082 -
Flags: first-review?(Bugzilla-alanjstrBugs) → first-review+
Same thing, for themes (sorry for missing this the first time) Makes line 601 match line 678.
Attachment #191083 -
Flags: first-review+
Attachment #191082 -
Attachment description: Make line 588 (top link) same as line 665 (bottom link) → Make line 588 (top link) same as line 665 (bottom link) [checked in]
Attachment #191083 -
Attachment description: Once again, for themes → Once again, for themes [checked in]
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 4•18 years ago
|
||
AMO BUGSPAM FOR COMPONENT MOVE AND DELETE (FILTER ME)
Component: Listings → Web Site
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•