301964 - Add IETF Atom 1.0 support to Thunderbird

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, enhancement)

Description

[Robert Sayre]

Atom is finalized, and we have a namespace to use.

Comment 1

[Robert Sayre]

Attachment: Add Atom 1.0 support to Thunderbird

Comment 2

[Robert Sayre]

Attachment: OPML file with Atom 1.0 feeds

Comment 3

[Scott MacGregor]

Comment on attachment 190346 [details] [diff] [review]
Add Atom 1.0 support to Thunderbird

this worked well for me. Great job as always.

I had one question about:

serializeTextConstruct: function(textElement)

are we doing the right thing with the content variable here? it looks like we
initialize it to null, then we change it to an empty string, then at the end of
the routine we flip it back to null.

Can that be optimized a big more? i.e. start with an empty string and then
return content directly instead of converting it back to null.

I made a couple very minor white space changes including: getting rid of  the
braces around single line if/else clauses.

Comment 4

[Robert Sayre]

(In reply to comment #3) 
> Can that be optimized a big more? i.e. start with an empty string and then
> return content directly instead of converting it back to null.

I've attached something a bit better, but returning null is the correct behavior
if we don't find anything in the content element (the storage code depends on it).

> I made a couple very minor white space changes including: getting rid of  the
> braces around single line if/else clauses.

Always forget that. Fixed.

Comment 5

[Robert Sayre]

Attachment: serializeTextConstruct fixed

Comment 6

[Scott MacGregor]

Comment on attachment 190499 [details] [diff] [review]
serializeTextConstruct fixed

I'm going to change:

+    if (content == "")
+      return null;
+    else
+      return content;

to
// we need to return null and not an empty string
return content ? content : null;

before I check in. Everything else looks good.

Comment 7

[Scott MacGregor]

fixed. thanks again for another great patch Robert. Keep 'em coming :)