301970 - window.open() for a given window fails the second time.

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect, P2)

Description

[Simon Fraser [no longer active]]

When a page uses window.open() to open a window, like:

window.open('http://www.smfr.org', 'window_name', 'scrollbars=0,resizable=no')

if you close the resulting window and click the button again, no window is opened.

My guess is that the nsWindowWatcher thinks the window is still around, so
refuses to open a 2nd one.

Comment 1

[Simon Fraser [no longer active]]

Attachment: Testcase

Comment 2

[Simon Fraser [no longer active]]

I debugged this. The code path between the working first click, and the broken
second click on the button diverges in nsJSEventListener::HandleEvent() on the

if (JS_TypeOfValue(cx, funval) != JSTYPE_FUNCTION)

test. The first time, funval is something reasonable. The second time, it's
0x80000001 so we bail.

I've no idea why this is broken. When the popup is closed, we're calling
nsWindowWatcher::RemoveWindow(), so it's not a nsWindowWatcher issue.

Comment 3

[Simon Fraser [no longer active]]

Possibly a recent regression, could break some sites.

Comment 4

[Simon Fraser [no longer active]]

First broke in 20050330. Checkins:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-03-29+08%3A00%3A00&maxdate=2005-03-30+08%3A00%3A00&cvsroot=%2Fcvsroot

Maybe regression from bug 283129 or bug 225563?

What's odd is that this is not a problem in DeerPark.

Comment 5

[Boris Zbarsky [:bzbarsky]]

The patch in bug 301316 should fix this.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Should probably retest in tomorrow's builds before resolving...

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The testcase in comment 2 works now (20050730), so marking this fixed per comment 5.