Closed
Bug 302173
Opened 19 years ago
Closed 19 years ago
JS engine doesn't work on PPC
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: wolfiR, Assigned: wolfiR)
Details
Attachments
(1 file)
882 bytes,
patch
|
shaver
:
review+
shaver
:
approval1.8b4+
|
Details | Diff | Splinter Review |
The following has been observed with Firefox 1.0.6 and Mozilla 1.7.10 on ppc architecture: - Firefox doesn't start at all - Mozilla starts and shows its userinterface but nothing can be done besides navigating through the interface (no action possible) After some investigation I've found that the stack direction is calculated wrong in jscpucfg.c if it's compiled with gcc 3.3.3 and -O2. That happens because the function StackGrowthDirection is inlined and therefore the behaviour is undefined. I propose the following patch.
Assignee | ||
Comment 1•19 years ago
|
||
Assignee: general → mozilla
Status: NEW → ASSIGNED
Attachment #190526 -
Flags: superreview?(shaver)
Attachment #190526 -
Flags: review?(shaver)
Comment on attachment 190526 [details] [diff] [review] forbid inlining for gcc What versions of gcc support noline? I think we probably need a version test here.
Attachment #190526 -
Flags: superreview?(shaver)
Attachment #190526 -
Flags: superreview-
Attachment #190526 -
Flags: review?(shaver)
Attachment #190526 -
Flags: review-
Assignee | ||
Comment 3•19 years ago
|
||
AFAIK the attribute is supported since gcc 3.1. Earlier versions just ignore it.
Comment on attachment 190526 [details] [diff] [review] forbid inlining for gcc r+a=shaver
Attachment #190526 -
Flags: superreview-
Attachment #190526 -
Flags: review-
Attachment #190526 -
Flags: review+
Attachment #190526 -
Flags: approval1.8b4+
Assignee | ||
Comment 5•19 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•19 years ago
|
Flags: testcase-
You need to log in
before you can comment on or make changes to this bug.
Description
•