Closed Bug 302173 Opened 19 years ago Closed 19 years ago

JS engine doesn't work on PPC

Categories

(Core :: JavaScript Engine, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: wolfiR, Assigned: wolfiR)

Details

Attachments

(1 file)

The following has been observed with Firefox 1.0.6 and Mozilla 1.7.10
on ppc architecture:

- Firefox doesn't start at all
- Mozilla starts and shows its userinterface but nothing can be done besides
  navigating through the interface (no action possible)

After some investigation I've found that the stack direction is calculated wrong
in jscpucfg.c if it's compiled with gcc 3.3.3 and -O2.
That happens because the function StackGrowthDirection is inlined and therefore
the behaviour is undefined.

I propose the following patch.
Assignee: general → mozilla
Status: NEW → ASSIGNED
Attachment #190526 - Flags: superreview?(shaver)
Attachment #190526 - Flags: review?(shaver)
Comment on attachment 190526 [details] [diff] [review]
forbid inlining for gcc

What versions of gcc support noline?  I think we probably need a version test
here.
Attachment #190526 - Flags: superreview?(shaver)
Attachment #190526 - Flags: superreview-
Attachment #190526 - Flags: review?(shaver)
Attachment #190526 - Flags: review-
AFAIK the attribute is supported since gcc 3.1. Earlier versions just ignore it.

Comment on attachment 190526 [details] [diff] [review]
forbid inlining for gcc

r+a=shaver
Attachment #190526 - Flags: superreview-
Attachment #190526 - Flags: review-
Attachment #190526 - Flags: review+
Attachment #190526 - Flags: approval1.8b4+
checked in
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Flags: testcase-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: