Closed Bug 302750 Opened 19 years ago Closed 19 years ago

Extension manager: can't install multiple updates anymore

Categories

(Toolkit :: Add-ons Manager, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: ria.klaassen, Assigned: robert.strong.bugs)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050729 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050729 Firefox/1.0+

In the Extension manager, the button Find Updates brings up a list of available
updates.
When I click Install Now, nothing happens.
The behaviour seems to have changed between ID 2005072812 and 2005072822. 

Reproducible: Always

Steps to Reproduce:
1. Make a new profile and put a folder with old extensions (I'll try to upload
them as an attachment) in the profile.
2. In the EM click the button Find Updates.
3. After some seconds (or sometimes minutes) a list with availlable updates  is
presented.
4. Click Install Now.

Actual Results:  
Nothing.

Expected Results:  
Firefox should download and install the updates.
Attached patch patch (obsolete) — Splinter Review
With the checkin of bug 302424 it appears that the command event is no longer
fired for the dialog buttons. This patch keeps the functionality generic as it
was previously and fixes the bug.
Assignee: nobody → rob_strong
Status: NEW → ASSIGNED
Attachment #191040 - Flags: review?(benjamin)
Flags: blocking-aviary1.5?
Comment on attachment 191040 [details] [diff] [review]
patch

I really don't like the substr(6) bit: raw numeric constants are almost always
a bad idea.

Please make a 'const kDialog = "dialog" and then use substr(kDialog.length) for
clarity.
Attachment #191040 - Flags: review?(benjamin) → review-
Attached patch patchSplinter Review
addresses comment
Attachment #191040 - Attachment is obsolete: true
Attachment #191430 - Flags: review?(benjamin)
Attachment #191430 - Flags: review?(benjamin)
Attachment #191430 - Flags: review+
Attachment #191430 - Flags: approval1.8b4+
Fixed on trunk

/cvsroot/mozilla/toolkit/mozapps/extensions/content/list.js,v  <--  list.js
new revision: 1.2; previous revision: 1.1
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Flags: blocking-aviary1.5?
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: