Closed
Bug 303095
Opened 19 years ago
Closed 19 years ago
Feedview: store default stylesheet URL in externalCSS preference
Categories
(Firefox Graveyard :: RSS Discovery and Preview, enhancement)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: myk, Unassigned)
References
Details
Currently we compose style from the default stylesheet and a user-supplied one, if any. This means users who want to create a completely new look for feeds have to override all rules in the default stylesheet, while users who just want to modify a subset of the look have to provide only the relevant rules. We could instead store the default stylesheet value in the preference so we use either the default stylesheet or a user-supplied one. Then complete new lookers wouldn't have to override all rules in the default, merely provide their own; and subsetters would have to copy the default stylesheet rules into their stylesheet. The latter approach is better, since it involves no complex analysis of existing rules. The worst case is a file copy or cut and paste, whereas the worst case for the current approach is carefully parsing the default stylesheet to determine what every rule does and whether/how to override it, plus debugging problems by examining the interaction of your rules and the default ones. We should adopt the latter approach. As a side-effect, it fixes bug 303049.
Comment 1•19 years ago
|
||
Fixing summary so it's discoverable.
Summary: store default stylesheet URL in externalCSS preference → Feedview: store default stylesheet URL in externalCSS preference
Updated•19 years ago
|
Component: General → RSS Discovery and Preview
Comment 2•19 years ago
|
||
Closing: Son of Feedview's "preview" display is going to be different enough to have brand new bugs.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → INVALID
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•