Closed
Bug 303699
Opened 19 years ago
Closed 19 years ago
Eliminate deprecated Bugzilla::DB routines from userprefs.cgi
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.22
People
(Reporter: wicked, Assigned: wicked)
References
Details
Attachments
(1 file)
4.75 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
These lines need to rewritten to use DBI: userprefs.cgi:48: SendSQL("SELECT realname FROM profiles WHERE userid = $userid"); userprefs.cgi:49: $vars->{'realname'} = FetchSQLData(); userprefs.cgi:52: SendSQL("SELECT tokentype, issuedate + " . $dbh->sql_interval('3 DAY') . userprefs.cgi:58: if(MoreSQLData()) { userprefs.cgi:59: my ($tokentype, $change_date, $eventdata) = &::FetchSQLData(); userprefs.cgi:79: my $old = SqlQuote($cgi->param('Bugzilla_password')); userprefs.cgi:80: SendSQL("SELECT cryptpassword FROM profiles WHERE userid = $userid"); userprefs.cgi:81: my $oldcryptedpwd = FetchOneColumn(); userprefs.cgi:96: my $cryptedpassword = SqlQuote(bz_crypt($pwd1)); userprefs.cgi:97: SendSQL("UPDATE profiles userprefs.cgi:133: SendSQL("UPDATE profiles SET " . userprefs.cgi:134: "realname = " . SqlQuote(trim($cgi->param('realname'))) . userprefs.cgi:313: SendSQL("SELECT DISTINCT name, description FROM groups " . userprefs.cgi:319: while (MoreSQLData()) { userprefs.cgi:320: my ($nam, $desc) = FetchSQLData(); userprefs.cgi:324: SendSQL("SELECT DISTINCT name, description FROM groups " . userprefs.cgi:326: while (MoreSQLData()) { userprefs.cgi:327: my ($nam, $desc) = FetchSQLData();
Assignee | ||
Updated•19 years ago
|
Assignee: general → wicked
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #199131 -
Flags: review?
Comment 2•19 years ago
|
||
Comment on attachment 199131 [details] [diff] [review] Rewrite deprecated SQL code, V1 >+ my $groups = $dbh->selectall_arrayref( >+ "SELECT DISTINCT name, description FROM groups WHERE id IN (" . >+ Bugzilla->user->groups_as_string . ") ORDER BY name"); Nit: maybe SELECT ... FROM ... WHERE ... ORDER BY ... would have been cleaner. But that's a nit. r=LpSolit
Attachment #199131 -
Flags: review? → review+
Updated•19 years ago
|
Status: NEW → ASSIGNED
Flags: approval?
Target Milestone: --- → Bugzilla 2.22
Updated•19 years ago
|
Flags: approval? → approval+
Comment 3•19 years ago
|
||
Checking in userprefs.cgi; /cvsroot/mozilla/webtools/bugzilla/userprefs.cgi,v <-- userprefs.cgi new revision: 1.88; previous revision: 1.87 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•