303865 - a11y: Should be able to select items in select1 via keypressed (not arrow keys)

Status: RESOLVED FIXED

(Core Graveyard :: XForms, enhancement)

Description

[Allan Beaufour]

Pressing f.x. "v" in a select1 should select the first element starting with a
"v", as a html:select does. Try f.x. attachment 190005 [details].

Comment 1

[aaronr]

*** Bug 316618 has been marked as a duplicate of this bug. ***

Comment 2

[aaronr]

Also, if you type out a value, that value should be selected.

Comment 3

[alexander :surkov (:asurkov)]

Attachment: testcase

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 5

[alexander :surkov (:asurkov)]

<method name="selectItemByLabel">
  <parameter name="aValue"/>
  <parameter name="aContextNode"/>

Last parameter is needless. Costs of testing :)

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 236826 [details] [diff] [review]
patch


>+            } else if (aEvent.charCode && !this.selectionOpen) {
>+              // Cache sequence of last pressed keys and search it in value of
>+              // xforms:label inside xforms:item elements.
>+              this.searchedHitCount++;
>+              window.setTimeout(
>+                function(aSelect) {
>+                  if (!--aSelect.searchidHitCount)
>+                    aSelect.searchedValue = "";
>+                },
>+                1000,
>+                this);

Why this timeout is needed? If you have a good reason, add a comment to the code too ;)
And why the timeout is 1sec?

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch2

(In reply to comment #6)
> 
> Why this timeout is needed? If you have a good reason, add a comment to the
> code too ;)
> And why the timeout is 1sec?
> 

Right, timeout is not needed. 1 sec is time of html:select http://lxr.mozilla.org/seamonkey/source/layout/forms/nsListControlFrame.cpp#105

Comment 8

[alexander :surkov (:asurkov)]

checked in by smaug for me

Comment 9

[aaronr]

checked into 1.8.0 branch on 2006/09/21

Comment 10

[aaronr]

checked into 1.8 branch on 2006/11/21