Closed Bug 303914 Opened 19 years ago Closed 19 years ago

legal_bugs_status should be spelled legal_bug_status in Bug.pm

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: ryan.gorsuch, Assigned: bugzilla-mozilla)

Details

Attachments

(2 files)

User-Agent:       Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 5.0; MRA 4.1 (build 00975); .NET CLR 1.0.3705)
Build Identifier: Bugzilla/2.18.3

In the file Bugzilla/Bug.pm, in the sub choices(), the hash $self->{choices}->
{bug_status} is set to the keyword @::legal_bugs_status which is a misspelling, 
and should be corrected to be @::legal_bug_status.

Reproducible: Always

Steps to Reproduce:
1. See the details for the location of this bug
Confirmed in CVS HEAD.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Trivial patch for Bugzilla BUGZILLA-2_18-BRANCH. Does not apply to 2.20 branch
/ HEAD. The legal_bug_status is only used for provide the choices hash (in 2.18
Bug.pm, didn't check others). The choices.bug_status does not seem to be used
in any template.
Assignee: create-and-change → bugzilla-mozilla
Status: NEW → ASSIGNED
Attachment #192000 - Flags: review?(mkanat)
Comment on attachment 192000 [details] [diff] [review]
Patch v1 against Bugzilla 2.18 branch

r=LpSolit

please submit a patch for 2.20/tip
Attachment #192000 - Flags: review?(mkanat) → review+
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: --- → Bugzilla 2.18
Patch for 2.20 and tip. Patch was made for 2.20 branch, but applies cleanly
(only line offset warning) to tip.
Attachment #192607 - Flags: review?(LpSolit)
Comment on attachment 192607 [details] [diff] [review]
Patch for 2.20 branch and tip (both updated 13 Aug 2005)

r=LpSolit
Attachment #192607 - Flags: review?(LpSolit) → review+
Flags: approval?
Flags: approval2.20?
Flags: approval2.18?
Just to clarify (since it's not mentioned anywhere on the bug, and I had to ask
on IRC before I got it), this is not just a misspelling, it's referencing a
non-existent variable because of the misspelling, thus always getting an empty
list.  Correcting the spelling makes it reference the existing variable, and
actually show a result.  So this is actually correcting a bug, and not just
fixing a spelling mistake.
Flags: approval?
Flags: approval2.20?
Flags: approval2.20+
Flags: approval2.18?
Flags: approval2.18+
Flags: approval+
tip:

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.88; previous revision: 1.87
done

2.20rc2:

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.81.2.1; previous revision: 1.81
done

2.18.3:

Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.37.2.5; previous revision: 1.37.2.4
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: