304352 - Percent complete isn't checkmarked in the task-list context menu

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Joey Minta]

In Sunbird 0.2, the task-list context menu displayed a checkmark next to the
appropriate percent-complete label.  This doesn't happen anymore.

Comment 1

[Joey Minta]

Attachment: use percentComplete

This section of the code hadn't been updated to use .percentComplete

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 192408 [details] [diff] [review]
use percentComplete

> 
>-      if( document.getElementById( "percent-"+toDoItem.percent+"-menuitem" ) )
>+      if( document.getElementById( "percent-"+toDoItem.percentComplete+"-menuitem" ) )
>       {
>-         document.getElementById( "percent-"+toDoItem.percent+"-menuitem" ).setAttribute( "checked", "true" );
>+         document.getElementById( "percent-"+toDoItem.percentComplete+
>+                       "-menuitem" ).setAttribute( "checked", "true" );

Nit: move the string generation on one line, like:
	 document.getElementById("percent-" + toDoItem.percentComplete +
"-menuitem").
		  setAttribute("checked", "true");
(also has some whitespace changes)

r=mvl with that.

Comment 3

[Joey Minta]

Patch checked in.