Closed
Bug 304418
Opened 19 years ago
Closed 19 years ago
"Save link as" and "Bookmark This Link" broken after bug #284868 checkin
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla1.8final
People
(Reporter: leaf.of.grass, Assigned: Gavin)
References
()
Details
(Keywords: fixed1.8, regression)
Attachments
(1 file, 1 obsolete file)
2.46 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8b4+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812 Firefox/1.0+ Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812 Firefox/1.0+ Right-click "Save Link As" is broken Reproducible: Always Steps to Reproduce: Testcase: http://tmp.gary.elixant.com/ 1. right-click tabmix+ beta .xpi and try to "save link as" 2. throws java script console error: Error: uncaught exception: [Exception... "Component returned failure code: 0x804b000a [nsIIOService.newURI]" nsresult: "0x804b000a (<unknown>)" location: "JS frame :: chrome://global/content/contentAreaUtils.js :: makeURI :: line 695" data: no] happens in current profile as well as new profile with no extensions. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050812 Firefox/1.0+ ID:2005081201 Actual Results: causes java script error Expected Results: should popup file download dialog Suspected regression from #284868 [Firefox]-HTTP Referer not sent at all when "saving link as..." checkin
Updated•19 years ago
|
Status: UNCONFIRMED → NEW
Component: General → Download Manager
Ever confirmed: true
QA Contact: general → download.manager
Comment 1•19 years ago
|
||
cc Jesse for bug 284868 related
Updated•19 years ago
|
Keywords: regression
Updated•19 years ago
|
Flags: blocking1.8b4?
Comment 2•19 years ago
|
||
Updated•19 years ago
|
Attachment #192546 -
Flags: review?(mconnor)
Comment 3•19 years ago
|
||
I will be traveling today, so it would be great if someone could check in this patch for me on trunk and the 1.8 branch when the tree opens (assuming the patch is reviewed and approved for the branch).
Comment 4•19 years ago
|
||
Workaround: Alt+click the link.
Comment 5•19 years ago
|
||
"Bookmark This Link..." is also broken.
Assignee | ||
Updated•19 years ago
|
Assignee: nobody → gavin.sharp
OS: Windows XP → All
Hardware: PC → All
Summary: "Save link as" broken after bug #284868 checkin → "Save link as" and "Bookmark Link" broken after bug #284868 checkin
Assignee | ||
Comment 6•19 years ago
|
||
Fix both.
Attachment #192546 -
Attachment is obsolete: true
Attachment #192606 -
Flags: review?(mconnor)
Assignee | ||
Updated•19 years ago
|
Attachment #192546 -
Flags: review?(mconnor)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Summary: "Save link as" and "Bookmark Link" broken after bug #284868 checkin → "Save link as" and "Bookmark This Link" broken after bug #284868 checkin
Target Milestone: --- → Firefox1.1
Updated•19 years ago
|
Attachment #192606 -
Flags: review?(mconnor)
Attachment #192606 -
Flags: review+
Attachment #192606 -
Flags: approval1.8b4+
Assignee | ||
Comment 7•19 years ago
|
||
Checked in branch and trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•19 years ago
|
Flags: blocking1.8b4?
Updated•19 years ago
|
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•