Closed
Bug 305184
Opened 19 years ago
Closed 18 years ago
Make nsIXFormsModelElement::getInstanceDocument raise DOMException
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: allan)
References
()
Details
(Keywords: fixed1.8.0.4, fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
|
3.40 KB,
patch
|
aaronr
:
review+
smaug
:
review+
|
Details | Diff | Splinter Review |
Currently we return NS_ERROR_FAILURE from nsXFormsModelElement::GetInstanceDocument(), but it should actually be a DOMException per the spec. The "raises(DOMException)" is commented out in the IDL, probably because the exact type of exception is unknown? Which NS_ERROR_DOM_* should we return?
|
Assignee | |
Comment 1•19 years ago
|
||
While we're messing with the function, how about reporting an error to the console?
|
|
Assignee | |
Comment 2•18 years ago
|
||
Returning DOM_NOT_FOUND error, and report errors.
Assignee: aaronr → allan
Attachment #193143 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #217029 -
Flags: review?(aaronr)
Attachment #217029 -
Flags: review?(aaronr) → review+
|
|
Assignee | |
Updated•18 years ago
|
Attachment #217029 -
Flags: review?(Olli.Pettay)
|
||
Updated•18 years ago
|
Attachment #217029 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: xf-to-branch
|
|
Assignee | |
Updated•18 years ago
|
Keywords: fixed1.8.0.3,
fixed1.8.1
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: xf-to-branch
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•