305228 - Change "prefs-sanitize" references to "prefs-clear-private-data"

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Jeff Walden (gone starting June 8)]

There are two, and the obsolete naming makes them confusing.  I wanted to make
this change in bug 304408 but decided it made more sense to isolate changes
outside help docs to another bug.  There won't be a problem with this on trunk,
but I'm hoping I can squeeze it in on branch as well.

Comment 1

[Jeff Walden (gone starting June 8)]

Attachment: Patch

Self-reviewing as a trivial bugfix, asking for approval...

Comment 2

[Jeff Walden (gone starting June 8)]

Comment on attachment 193196 [details] [diff] [review]
Patch

After more consideration, it's clear that this is a fix that doesn't do
anything except create more work for localizers, so I've only committed it to
trunk; the branch will be just fine with a slightly-less-accurate name.

Comment 3

[Jeff Walden (gone starting June 8)]

For the record, I got an r=mconnor over IRC, which I'd forgotten I needed
because the patch changes one file that isn't help-specific.

Anyway, patch checked in on trunk, so marking FIXED...

Regarding the blocking1.8bx+ flags, I tried to clear them but was told I
couldn't, so to whichever release manager comes around to follow up here, this
is not checked into the branch and will not be checked in because after thinking
about it a bit more it's not really needed there.

Comment 4

[Steffen Wilberg]

Comment on attachment 193196 [details] [diff] [review]
Patch

This needs to be checked in before I can check in bug 306431.

Comment 5

[Benjamin Smedberg]

Comment on attachment 193196 [details] [diff] [review]
Patch

Steffen, any patch which touches browser/* only is automatically approved for the 1.8.1 branch.

Comment 6

[Steffen Wilberg]

1.8 branch:
Checking in mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf,v  <--  firebird-toc.rdf
new revision: 1.34.2.9; previous revision: 1.34.2.8
done
Checking in mozilla/browser/components/preferences/sanitize.xul;
/cvsroot/mozilla/browser/components/preferences/sanitize.xul,v  <--  sanitize.xul
new revision: 1.9.2.2; previous revision: 1.9.2.1
done