305243 - xmlHttpRequest mishandles local xml files

Status: RESOLVED FIXED

(Core :: XML, defect, P1)

Description

[Sean McMurray]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.11) Gecko/20050729
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.11) Gecko/20050729

A well-formed, valid xsl file loaded from local disk via xmlHttpRequest has
valid contentText, but contentXML is null.

Mozilla seems to think the document is not XML.

(Local mime type for .xsl files is text/xsl.)

Reproducible: Always

Steps to Reproduce:
1.load local file with non-XML mime type via xmlHttpRequest
2.display xmlHttpRequest.contentXML

Actual Results:  
contentXML is null

Expected Results:  
The contentXML should be an XMLDocument.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 193210 [details] [diff] [review]
patch

r=jst

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on trunk:
Checking in xmlextras/base/src/nsXMLHttpRequest.cpp;
/cvsroot/mozilla/extensions/xmlextras/base/src/nsXMLHttpRequest.cpp,v  <-- 
nsXMLHttpRequest.cpp
new revision: 1.136; previous revision: 1.135
done
Checking in xmlextras/tests/TestXMLExtras.cpp;
/cvsroot/mozilla/extensions/xmlextras/tests/TestXMLExtras.cpp,v  <-- 
TestXMLExtras.cpp
new revision: 1.24; previous revision: 1.23
done

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 193210 [details] [diff] [review]
patch

this is a low risk patch to make XMLHttpRequest behave better for file:// URIs,
this'd be nice to have in 1.8.

Comment 5

[Asa Dotzler [:asa]]

cbiesinger, how is this used and why is it important?

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Extensions can use this to load XML files from the local disk. This is important
because without it, loading (say) "foo.xsl" might or might not work, depending
on OS configuration.

Comment 7

[Asa Dotzler [:asa]]

please add the fixed1.8 keyword when you land this on the branch

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on MOZILLA_1_8_BRANCH
Checking in extensions/xmlextras/base/src/nsXMLHttpRequest.cpp;
/cvsroot/mozilla/extensions/xmlextras/base/src/nsXMLHttpRequest.cpp,v  <-- 
nsXMLHttpRequest.cpp
new revision: 1.134.2.1; previous revision: 1.134
done
Checking in extensions/xmlextras/tests/TestXMLExtras.cpp;
/cvsroot/mozilla/extensions/xmlextras/tests/TestXMLExtras.cpp,v  <-- 
TestXMLExtras.cpp
new revision: 1.23.4.1; previous revision: 1.23
done

Comment 9

[Simon Bünzli]

Is it intentional that XMLHttpRequest can retrieve any type of content from the
web but only XML data from local files? I found it at least somewhat confusing
that one of my extensions suddenly stopped working because of a not further
specified NS_ERROR_FAILURE in nsIXMLHttpRequest.Send.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

not at all. please file a new bug with testcase.

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

(that's bug 309078 now)

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

I backed this patch out of the 1.8 branch because it caused bug 309078; see also
that bug for the reasoning. if people do think we should have this on the
branch, we need to take bug 293046 too.