Closed Bug 305447 Opened 19 years ago Closed 19 years ago

packager.mk doesn't leave safe symbolic links alone

Categories

(Firefox Build System :: General, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mark, Assigned: mark)

Details

(Keywords: fixed1.8)

Attachments

(1 file)

packager.mk shouldn't interfere with safe symbolic links.  A safe symlink is
relative and points within the tree.  Such links should be preserved in the
packaged dmg rather than copying the link's referent.

rsync has an option, --copy-unsafe-links, which produces the desired behavior. 
It should replace -L (--copy-links) when rsync is used in packager.mk. 
--copy-unsafe-links is used elsewhere in the build (although nowhere that it
would currently make a difference) and is supported in the rsync versions
present on all supported Mac build platforms.

This is causing slight bloat in Camino now that it's moved to the mainstream
packager, because Camino bundles a framework and frameworks are notoriously
populated with all sorts of symlinks pointing within themselves.  This change
will not interfere with other packaged applications, which don't currently
include any safe symlinks.
Attached patch PatchSplinter Review
If it's all the same to everyone else, I'd like this for 1.8b4.  It's a size
regression for Camino, and the patch is safe.
Attachment #193388 - Flags: review?(benjamin)
Attachment #193388 - Flags: approval1.8b4?
Attachment #193388 - Flags: review?(benjamin) → review+
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
getting this fix on the radar by requesting 1.8b4
Flags: blocking1.8b4?
Attachment #193388 - Flags: approval1.8b4? → approval1.8b4+
Flags: blocking1.8b4? → blocking1.8b4+
Keywords: fixed1.8
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: