305505 - some preferences windows are not wide enough, wrong accesskey for clear private date setttings and prefs title not translated

Status: RESOLVED FIXED

(Mozilla Localizations :: de / German, defect)

Description

[Ronny Perinke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8b4) Gecko/20050819 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8b4) Gecko/20050819 Firefox/1.0+

- the main pref window and the fonts window are to small (also on unix)

- wrong accesskey ->
http://lxr.mozilla.org/l10n/source/de/browser/chrome/browser/preferences/privacy.dtd#55

- not localized title ->
http://lxr.mozilla.org/l10n/source/de/browser/chrome/browser/preferences/preferences.dtd#11

Reproducible: Always

Comment 1

[Ronny Perinke]

Attachment: patch

p.s.
for Firefox 1.5 Branch locales of course

Comment 2

[Ronny Perinke]

Attachment: screenshot

Comment 3

[Adam Guthrie]

Dupe/related to bug 283697?

Comment 4

[Ronny Perinke]

(In reply to comment #3)
> Dupe/related to bug 283697?

Making the prefs windows resizable is one thing, but it should not be necessary
by default (with default themes and fonts) to resize them - that's the point.

You need to resize them, if you use other themes and fonts where they are cropded.


p.s.
I just noticed that the findPrevious accesskey of the findbar is wrong, too.
http://lxr.mozilla.org/l10n/source/de/toolkit/chrome/global/findbar.dtd#8

Comment 5

[Martin Creutziger [:MMx]]

I think we need to look over all the window sizes again, I am also experiencing
a stange behaviour here on Mac...

Comment 6

[Kadir Topal [:atopal]]

okay, fixed some of the sizes, but I can't change the height of the security and
the sanitize panel, so the groupbox is chopped off. Changing the value in
preferences.dtd changes the size of the surrounding space only.

Comment 7

[Kadir Topal [:atopal]]

MMx can you tell me the correct sizes for Mac OS X?

Comment 8

[Martin Creutziger [:MMx]]

sure.

In browser/preferences/preferences.dtd:
<!ENTITY prefWindow.styleMac "width: 52em;">

In browser/preferences/sanitize.dtd:
<!ENTITY window.width "38em">

The latter entity affects Windows and Linux, too. But it has to be wide enough
for the first line of text to fit in one line, otherwise the last option gets
cropped (not only the group box).

Comment 9

[Martin Creutziger [:MMx]]

another 3 items I found:

in browser/preferences/languages.dtd
<!ENTITY window.width "37em">

in browser/preferences/colors.dtd
<!ENTITY window.width "44em">
This entity affects all platforms again, but do we have a choice?

in browser/preferences/fonts.dtd
<!ENTITY window.macWidth "47em">

Comment 10

[Kadir Topal [:atopal]]

Done, but there is still the problem with the cropped groupbox :-/

Comment 11

[Martin Creutziger [:MMx]]

Attachment: patch to reflect remaining changes

patch to make the remaining changes. Checked in on BRANCH.

Comment 12

[Kadir Topal [:atopal]]

This is fixed with the latest RC2.