Closed
Bug 305520
Opened 19 years ago
Closed 19 years ago
GtkPromptService invalid warning on ConfirmEx with < 3 buttons
Categories
(Core Graveyard :: Embedding: GTK Widget, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chpe, Assigned: chpe)
Details
(Keywords: fixed1.8)
Attachments
(1 file)
1.02 KB,
patch
|
mpgritti
:
review+
roc
:
superreview+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
Steps to reproduce: 0) run TestGtkEmbed 1) Go to http://foo@gnome.org/ Results: WARNING: Unexpected button flags, file /opt/source/mozilla/1.8-ff/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp, line 346 The 'unexpected' flag is 0. This happens when determining the label of the 3rd button, and flags is 0 because there are only 2. nsIPromptService.idl for ConfirmEx says "Puts up a dialog with up to 3 buttons and an optional, labeled checkbox.", so this is NOT unexpected. Simple fix coming up.
Assignee | ||
Comment 1•19 years ago
|
||
Updated•19 years ago
|
Attachment #193456 -
Flags: review?(mpgritti) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #193456 -
Flags: superreview?(roc)
Comment on attachment 193456 [details] [diff] [review] fix only affects Gtk embedding
Attachment #193456 -
Flags: superreview?(roc)
Attachment #193456 -
Flags: superreview+
Attachment #193456 -
Flags: approval1.8b5?
Updated•19 years ago
|
Attachment #193456 -
Flags: approval1.8b5? → approval1.8b5+
Comment 3•19 years ago
|
||
trunk: Checking in embedding/browser/gtk/src/GtkPromptService.cpp; /cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,v <-- GtkPromptService.cpp new revision: 1.10; previous revision: 1.9 done MOZILLA_1_8_BRANCH: Checking in embedding/browser/gtk/src/GtkPromptService.cpp; /cvsroot/mozilla/embedding/browser/gtk/src/GtkPromptService.cpp,v <-- GtkPromptService.cpp new revision: 1.8.2.2; previous revision: 1.8.2.1 done
Updated•12 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•