Closed
Bug 305912
Opened 19 years ago
Closed 19 years ago
Popup notification bar doesn't appear on first load (e.g. if your homepage tries to open a popup) , and doesn't correctly list all blocked popups
Categories
(Firefox :: General, defect, P2)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 2 alpha1
People
(Reporter: Gavin, Assigned: Gavin)
References
()
Details
(Keywords: verified1.8.1)
Attachments
(1 file)
3.68 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
While fixing bug 304727, I noticed two bugs with blocked popup notification: 1) If the first page loaded has a blocked popup, the popup notification bar doesn't appear as it should. 2) If multiple popups are blocked, the popup notification message doesn't correctly indicate that ("x popups were blocked ...") In both cases, switching tabs updates the message correctly. Patch coming up.
Assignee | ||
Comment 1•19 years ago
|
||
Creates the pref service if it doesn't exist when receiving the first onPopupBlocked event, and updates the browser message after each onPopupBlocked so that the correct count is displayed the first time.
Attachment #193814 -
Flags: review?(mconnor)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Firefox1.6-
Comment 2•19 years ago
|
||
Comment on attachment 193814 [details] [diff] [review] patch this works for now, but I think we need to a) check all usage of gPrefService here and b) add a helper function like ensurePrefService() so its less ugly. Can you file a followup and nominate for blocking-aviary2.0 please?
Attachment #193814 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 3•19 years ago
|
||
Checking in toolkit/content/widgets/browser.xml; /cvsroot/mozilla/toolkit/content/widgets/browser.xml,v <-- browser.xml new revision: 1.74; previous revision: 1.73 done Checking in browser/base/content/browser.js; /cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js new revision: 1.497; previous revision: 1.496 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•19 years ago
|
Flags: blocking-aviary2?
Assignee | ||
Updated•19 years ago
|
Attachment #193814 -
Flags: approval1.8.1?
Updated•19 years ago
|
Attachment #193814 -
Flags: approval1.8.1? → approval1.8.1+
Updated•19 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Assignee | ||
Comment 4•19 years ago
|
||
Checked in on the 1.8 branch for Firefox 2. mozilla/browser/base/content/browser.js; new revision: 1.479.2.46; mozilla/toolkit/content/widgets/browser.xml; new revision: 1.70.2.4;
Keywords: fixed1.8.1
Assignee | ||
Updated•19 years ago
|
Target Milestone: Firefox 2 → Firefox 2 alpha1
Assignee | ||
Comment 5•18 years ago
|
||
VERIFIED FIXED: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060819 BonEcho/2.0b2 Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060821 Minefield/3.0a1
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•