305975 - Height:0% is not the same as height:0px inside a table

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase.
Both tables and button inside it are identical, only the first has height:0% and
the second has height:0px.
They should render the same, but they don't.

I saw this when looking at distrowatch.com.

bz	{#developers} mw22: oh, tables....
bz	{#developers} mw22: hrm... file a bug? ;)
bz	{#developers} mw22: and make sure to cc bernd...

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

The bug can also be seen in Mozilla1.7.

Comment 2

[Worcester12345]

Is this feature any part of the "Acid 2" test?

Comment 3

[Bernd]

the percent height observer stuff is obviously not limited to quirks mode as it
should be. The questions is only where to cut it.

Comment 4

[Bernd]

Attachment: patch

cut it at the cell level where it seems to start.

Comment 5

[Bernd]

>Both tables and button inside it are identical, only the first has height:0% and
>the second has height:0px.
>They should render the same, but they don't.
They should not render identical in standards mode a percentage base height
inside auto height becomes itself auto. So its height: auto vs 0px.

Comment 6

[Martijn Wargers (dead)]

Ah, I see. So the patch seems to fix http://www.distrowatch.com broken layout
(because distrowatch is in standards mode).
The mentioning of the broken layout at distrowatch.com (buttons and stuff
overflowing table cells) was here:
http://forums.mozillazine.org/viewtopic.php?p=1704044

Comment 7

[amano]

Maybe this should be chosen for the branch. If it is  not a risky patch, then
please nominate it. 

Comment 8

[Bernd]

fix checked in

Comment 9

[sbporter]

"The set of bugs blocking beta1 is tracked by the blocking1.8b4 flag . This list
is the set of bugs which truly have to be done before a more public release.
These are large/risky patches, common crashes, or break commonly used websites."
http://developer.mozilla.org/devnews/index.php/2005/08/30/9-days-untill-15-beta/

This would seem to fit in the "broken commonly used websites" (assuming that is
what they meant to say) category, could this possibly be checked into the branch?

Comment 10

[Asa Dotzler [:asa]]

bernd, bz, is this branch worthy?

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 194052 [details] [diff] [review]
patch

I believe it is, yes.  This makes a table quirk only happen in quirks mode. 
Only standards-mode stuff is affected, and probably only for the better.

Comment 12

[Boris Zbarsky [:bzbarsky]]

*** Bug 293372 has been marked as a duplicate of this bug. ***

Comment 13

[Boris Zbarsky [:bzbarsky]]

Fixed on branch.