Closed Bug 306185 Opened 19 years ago Closed 19 years ago

Mac updater description string is cropped

Categories

(Toolkit :: Application Update, defect, P1)

1.8.0 Branch
PowerPC
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla1.8final

People

(Reporter: asaf, Assigned: asaf)

References

Details

(Keywords: regression, verified1.8)

Attachments

(2 files, 1 obsolete file)

12.71 KB, image/png
Details
5.22 KB, application/octet-stream
mark
: review+
Details
The mac updater description string is cut right after the word "few".
Summary: Mac updater description string is cut → Mac updater description string is cropped
Attached image Screenshot
Flags: blocking1.8b4?
Target Milestone: --- → Firefox1.5
Attached file new nib (obsolete) —
Assignee: joshmoz → bugs.mano
Status: NEW → ASSIGNED
Attachment #194050 - Flags: review?(joshmoz)
Keywords: regression
Priority: -- → P1
*** Bug 306215 has been marked as a duplicate of this bug. ***
Flags: blocking1.8b4? → blocking1.8b4+
Attachment #194050 - Flags: review?(joshmoz) → review?(mark)
Attached file keyedobjects.nib
Attachment #194226 - Flags: review?(mark)
Attachment #194050 - Attachment is obsolete: true
Attachment #194050 - Flags: review?(mark)
Attachment #194226 - Flags: review?(mark) → review+
Attachment #194226 - Flags: approval1.8b4?
*** Bug 306367 has been marked as a duplicate of this bug. ***
Checking in Contents/Resources/English.lproj/MainMenu.nib/keyedobjects.nib;
/cvsroot/mozilla/toolkit/mozapps/update/src/updater/macbuild/Contents/Resources/English.lproj/MainMenu.nib/keyedobjects.nib,v
 <--  keyedobjects.nib
new revision: 1.5; previous revision: 1.4
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Attachment #194226 - Flags: approval1.8b4? → approval1.8b4+
1.8 Branch:
Checking in Contents/Resources/English.lproj/MainMenu.nib/keyedobjects.nib;
/cvsroot/mozilla/toolkit/mozapps/update/src/updater/macbuild/Contents/Resources/English.lproj/MainMenu.nib/keyedobjects.nib,v
 <--  keyedobjects.nib
new revision: 1.4.2.1; previous revision: 1.4
done
Keywords: fixed1.8
Asaf, it's hard totell from this binary patch what changed to fix this. Did we
end up shortening the string or making the dialog wider to accomodate the text?
Blocks: 306127
This has made the label as wide as the progress bar in the updater window.
(In other words, no strings changes)
Looks good using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
rv:1.8b5) Gecko/20050929 Firefox/1.4. Adding verified keyword.
Keywords: fixed1.8verified1.8
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: