306223 - Allow to easily filter errors by category

Status: RESOLVED FIXED

(Toolkit Graveyard :: Error Console, enhancement)

Description

[Simon Bünzli]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050827 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050827 Firefox/1.0+

The attached one-line patch allows extensions to very easily filter out unwanted
categories. This would come in handy, as the JS Console is about to be used for
non-JS warnings/errors as well.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Simon Bünzli]

Attachment: patch

Comment 2

[Dave Townsend [:mossop]]

Maybe a dupe of bug 302211

Comment 3

[Simon Bünzli]

Bug 302211 is a request to add filtering UI or a pref. This bug is just about a
back-end patch, providing a standard method for extension authors (such as
myself) to add the UI.

Comment 4

[Peter van der Woude [:Peter6]]

*** This bug has been marked as a duplicate of 275265 ***

Comment 5

[Simon Bünzli]

No duplicate of bug 275265, either, since that bug is also about UI, while this
one is about a simple back-end change (see the attached patch).

Comment 6

[Simon Bünzli]

What are the chances of seeing either this one or one of the two dupe candidates
(bug 302211 and bug 275265) fixed in time for Firefox 1.5?

This would considerably speed up the console's loading time when Console Filter
is installed (cf. http://forums.mozillazine.org/viewtopic.php?p=1734462#1734462
). In general, the attached patch would allow for a much cleaner way of
filtering the console without having to dive into XBL idiosyncracies, allowing
to use either CSS or JS for filtering - making it thus more straightforward for
extensions to provide any of the functionality of the mentioned bugs.

Comment 7

[Asa Dotzler [:asa]]

We're too far into this release to be considering feature additions like this.
You should work on getting this landed on the trunk for the next major release
after 1.5.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/console/content/consoleBindings.xml 	1.10

Comment 9

[Simon Bünzli]

Since bug 312962 seems to be going nowhere, this one-line patch would at least make it considerably easier for extension authors to work around the console's current limitations.

Comment 10

[Mike Connor [:mconnor]]

Not going to block on this, but will take the patch?

Comment 11

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/components/console/content/consoleBindings.xml 	1.9.2.1

Comment 12

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-XPFE) <consoleBindings.xml> [Checkin: Comment 14 & 16]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1b1) Gecko/20060717 SeaMonkey/1.1a] (nightly) (W98SE)

Port Toolkit patch to XPFE.

I've been running with this for half a day, without noticing any issue:
warnings/errors/exceptions still display as before.

Comment 13

[Serge Gautherie (:sgautherie)]

Comment on attachment 229629 [details] [diff] [review]
(Bv1-XPFE) <consoleBindings.xml>
[Checkin: Comment 14 & 16]

'approval1.8.1=?': (XPFE only)
Trivial U.I. code addition, sync'ing with Toolkit, no risk.

Comment 14

[Martijn Wargers (dead)]

Checking in consoleBindings.xml;
/cvsroot/mozilla/xpfe/components/console/resources/content/consoleBindings.xml,v
  <--  consoleBindings.xml
new revision: 1.25; previous revision: 1.24
done

Checked Bv1-XPFE patch in on trunk.

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 229629 [details] [diff] [review]
(Bv1-XPFE) <consoleBindings.xml>
[Checkin: Comment 14 & 16]

a=drivers. Please go ahead and land this on the branch.

Comment 16

[Martijn Wargers (dead)]

Checking in consoleBindings.xml;
/cvsroot/mozilla/xpfe/components/console/resources/content/consoleBindings.xml,v
  <--  consoleBindings.xml
new revision: 1.23.8.2; previous revision: 1.23.8.1
done

Checked Bv1-XPFE patch in on 1.8.1 branch.

Comment 17

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1b1) Gecko/20060725 SeaMonkey/1.1a] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_BRANCH, by looking at packaged file, since this code is not directly used.