Closed Bug 306351 Opened 19 years ago Closed 19 years ago

crash in nsFilePicker.cpp on OSX

Categories

(Core Graveyard :: Widget: Mac, defect)

1.8 Branch
PowerPC
macOS
defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: shanec, Assigned: shanec)

Details

(Keywords: crash, verified1.8)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

If you use too many file filters, you can crash and burn.  patch that fixes the
crash to be attached...

Reproducible: Always

Steps to Reproduce:
Component: General → XP Toolkit/Widgets
Product: Firefox → Core
Version: unspecified → 1.8 Branch
ccing a bunch of mac folks
Assignee: nobody → joshmoz
Component: XP Toolkit/Widgets → Widget: Mac
QA Contact: general → mac
Keywords: crash
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 194207 [details] [diff] [review]
fix for crash in nsFilePicker.cpp

Looks good. Thanks for the patch!

We may want to consider some kind of warning to the console if you use too many
filters, since it seems some are going to get ignored silently.
Attachment #194207 - Flags: review+
Attachment #194207 - Flags: superreview+
Assignee: joshmoz → shanec
Attachment #194207 - Flags: approval1.8b4?
This is a very safe patch, and should go in on the branch.
Attachment #194207 - Flags: approval1.8b4? → approval1.8b4+
checked in on trunk and 1.8 branch
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Keywords: fixed1.8
Status: RESOLVED → VERIFIED
Keywords: fixed1.8verified1.8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: