Closed Bug 306534 Opened 19 years ago Closed 19 years ago

[FIX]###!!! ASSERTION: Float frame has wrong parent: 'floatFrame->GetParent() == mBlock', file nsBlockReflowState.cpp, line 835

Categories

(Core :: Layout: Block and Inline, defect, P1)

Product:
Core
Component:
Layout: Block and Inline
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: MatsPalmgren_bugz, Assigned: bzbarsky)

References

Details

(Keywords: testcase, verified1.8.1.13)

Attachments

(3 files)

Testcase
606 bytes, text/html
Details
GDB data + stack
14.30 KB, text/plain
Details
Fix
1.56 KB, patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review 
###!!! ASSERTION: Float frame has wrong parent: 'floatFrame->GetParent() ==
mBlock', file nsBlockReflowState.cpp, line 835

STEPS TO REPRODUCE
1. load the attached testcase
Attached file Testcase — 

    
    

    
  

      
      
      
      

        Attached file
          
        GDB data + stack
        — 
      

    


  

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix
        — 
          — Splinter Review
      

    


  
Just have to get the right parent when initing the floating letter frame.

Note that this does not help with the fact that we show the first letter twice; not sure why that happens...
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED

        Attachment #205284 -
        Flags: superreview?(roc)

        Attachment #205284 -
        Flags: review?(roc)

    
  
Priority: -- → P1
Summary: ###!!! ASSERTION: Float frame has wrong parent: 'floatFrame->GetParent() == mBlock', file nsBlockReflowState.cpp, line 835 → [FIX]###!!! ASSERTION: Float frame has wrong parent: 'floatFrame->GetParent() == mBlock', file nsBlockReflowState.cpp, line 835
Target Milestone: --- → mozilla1.9alpha

        Attachment #205284 -
        Flags: superreview?(roc)

        Attachment #205284 -
        Flags: superreview+

        Attachment #205284 -
        Flags: review?(roc)

        Attachment #205284 -
        Flags: review+

    
    

    
  
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Blocks: 415827

    
    

    
  
The patch was merged to MOZILLA_1_8_BRANCH by bug 415827 so adding
fixed1.8.1.13 keyword.
Keywords: fixed1.8.1.13

    
  
Flags: in-testsuite?

    
    

    
  
Verified fixed on the 1.8.1 branch. After updating my 1.8.1 debug build, I don't see the assertion anymore with the testcase.
Keywords: fixed1.8.1.13 → verified1.8.1.13

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: