Closed
Bug 306881
Opened 19 years ago
Closed 19 years ago
fix canvas pattern repeat attribute
Categories
(Core :: Graphics: Canvas2D, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: vlad, Assigned: vlad)
Details
(Keywords: fixed1.8)
Attachments
(1 file)
4.61 KB,
patch
|
pavlov
:
review+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
Right now canvas patterns aren't set to repeat like the should be per the spec. This fixes this, and also fixes a late spec change to arc().
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #194697 -
Flags: review?(pavlov)
Attachment #194697 -
Flags: approval1.8b5?
Updated•19 years ago
|
Attachment #194697 -
Flags: review?(pavlov) → review+
Updated•19 years ago
|
Attachment #194697 -
Flags: approval1.8b5? → approval1.8b5+
Comment 2•19 years ago
|
||
Vladimir, Changing the arc method to reflect the changes in the spec makes it incompatible with Safari's implementation. Drawing arcs clockwise or counterclockwise is completely different and would result in a faulty rendered image in one or the other. I don't know what Hixie's reasons where for changing this but this would make it impossible to write a cross browser script without doing some sort off browser sniffing. I would stick with the current solution since that doesn't break anything.
Assignee | ||
Comment 3•19 years ago
|
||
It doesn't create an inconsistency, unless I screwed up somewhere; Safari had a documentation error, whereas their implementation does what this does. We agreed with the Safari devs to just change the documentation.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 4•19 years ago
|
||
Your absolutely right.
You need to log in
before you can comment on or make changes to this bug.
Description
•