Closed
Bug 307178
Opened 19 years ago
Closed 19 years ago
Fastback(bfcache) breaks visited links marking if frame page
Categories
(Core :: DOM: Navigation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: masayuki, Assigned: bryner)
References
()
Details
(Keywords: fixed1.8, qawanted)
Attachments
(1 file)
666 bytes,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
mtschrep
:
approval1.8rc2+
|
Details | Diff | Splinter Review |
1. See frame page. (e.g., http://www.cgl.ucsf.edu/chimera/docs/ProgrammersGuide/Examples/ ) 2. Select "Show Only This Frame" in any frame. 3. Back to frame page by back button. 4. Click left frame's link. The clicked link isn't marked to visited. This problem is only occured with Fastback(bfcache).
Comment 1•19 years ago
|
||
I can reproduce on Trunk/Linux. Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050906 Firefox/1.6a1
Reporter | ||
Updated•19 years ago
|
OS: Windows XP → All
Assignee | ||
Updated•19 years ago
|
Assignee: nobody → roc
Brian, this is happening because subframe documents don't get OnPageShow notifications. Is that the expected behaviour? Can you suggest how I can detect that the subframe document is alive again?
Comment 3•19 years ago
|
||
Is this depend on bug 274784?
Updated•19 years ago
|
Blocks: blazinglyfastback
Assignee | ||
Comment 4•19 years ago
|
||
(In reply to comment #2) > Brian, this is happening because subframe documents don't get OnPageShow > notifications. Is that the expected behaviour? Can you suggest how I can detect > that the subframe document is alive again? This is not the expected behavior -- pageshow events should be firing. It's possible that this is caused by bug 312117, if it's trunk-only.
Assignee | ||
Comment 5•19 years ago
|
||
It's not that, this happens on the branch as well.
Assignee | ||
Comment 6•19 years ago
|
||
We have to clear mEODForCurrentDocument as we start the fake loads for subframes, or they won't notify the content viewer in EndPageLoad, which in turn won't call nsDocument::OnPageShow.
Assignee: roc → bryner
Status: NEW → ASSIGNED
Attachment #201490 -
Flags: superreview?(bzbarsky)
Attachment #201490 -
Flags: review?(bzbarsky)
Comment 7•19 years ago
|
||
Comment on attachment 201490 [details] [diff] [review] patch Seems reasonable. Probably worth getting in on branch too...
Attachment #201490 -
Flags: superreview?(bzbarsky)
Attachment #201490 -
Flags: superreview+
Attachment #201490 -
Flags: review?(bzbarsky)
Attachment #201490 -
Flags: review+
Assignee | ||
Comment 8•19 years ago
|
||
checked in on trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•19 years ago
|
||
Comment on attachment 201490 [details] [diff] [review] patch Requesting rc2 approval. I think this fix is really safe, and it addresses a noticeable issue for users who use link coloring to figure out where they've been.
Attachment #201490 -
Flags: approval1.8rc2?
It's not just that, right? Is it not also an API issue for Web developers who expect to receive these events?
Assignee | ||
Comment 11•19 years ago
|
||
That too.
Comment 13•19 years ago
|
||
I'll do the verify today.
Comment 14•19 years ago
|
||
Comment on attachment 201490 [details] [diff] [review] patch Approved r.e. discussion in bug triage today.
Attachment #201490 -
Flags: approval1.8rc2? → approval1.8rc2+
Component: History: Session → Document Navigation
QA Contact: history.session → docshell
You need to log in
before you can comment on or make changes to this bug.
Description
•