Closed
Bug 307469
Opened 19 years ago
Closed 19 years ago
jsopcode.c doesn't build w/ !JS_HAS_XML_SUPPORT
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
(Keywords: fixed1.8)
Attachments
(1 file, 1 obsolete file)
|
1.59 KB,
patch
|
Details | Diff | Splinter Review |
jsopcode.c(941) : error C2065: 'inXML' : undeclared identifier jsopcode.c(2062) : error C2065: 'inXML' : undeclared identifier
Attachment #195241 -
Flags: review?(brendan)
|
||
Comment 3•19 years ago
|
||
Comment on attachment 195241 [details] [diff] [review] option 1 Nice minimal patch. Nit: move that #undef up, the other local macros use FIFO, not LIFO, order of #undef with respect to #define. Thanks, this should go into the 1.8 branch when it opens after beta1 is tagged. /be
Attachment #195241 -
Flags: review?(brendan)
Attachment #195241 -
Flags: review+
Attachment #195241 -
Flags: approval1.8b5+
Comment on attachment 195241 [details] [diff] [review] option 1 mozilla/js/src/jsopcode.c 3.92 mozilla/js/src/jsopcode.c 3.89.2.3
Attachment #195241 -
Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Comment 6•19 years ago
|
||
seems this did land on the branch. please add the fixed1.8 keyword when you land things on the branch. thanks.
Keywords: fixed1.8
|
||
Updated•19 years ago
|
Flags: testcase-
You need to log in
before you can comment on or make changes to this bug.
Description
•