307925 - Installing extensions with guids with a trailing / cause an unknown error.

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

The test for valid guids in the extension manager allows a trailing /.
Installation then fails when trying to create a directory with that name with
the following error in the JavaScript console:

Error: [Exception... "Component returned failure code: 0x80520001
(NS_ERROR_FILE_UNRECOGNIZED_PATH) [nsIFile.append]"  nsresult: "0x80520001
(NS_ERROR_FILE_UNRECOGNIZED_PATH)"  location: "JS frame ::
file:///C:/Program%20Files/Deer%20Park%20Alpha%202/components/nsExtensionManager.js
:: anonymous :: line 1085"  data: no]
Source File:
file:///C:/Program%20Files/Deer%20Park%20Alpha%202/components/nsExtensionManager.js
Line: 1085

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch

This patch simply removes the optional trailing slash from the regular
expression that is used to test for valid guids.

This is a pretty minor issue and should only really stop some confusion for
extension authors who might make the mistake.

Comment 2

[Robert Strong (they/them - no direct email)]

Benjamin - was there a reason the ext id regexp allowed an optional '/' on the
end of the id?

Comment 3

[Benjamin Smedberg]

Ben wrote the original regexp: IIRC, it was checking directory names and he was
having problems with a trailing slash. I'm hoping that we changed to use
leafnames since then.

Comment 4

[Robert Strong (they/them - no direct email)]

Thanks and that makes sense. I had already verified it does use the leafName
everywhere the regexp is used so this should be good to go.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.153; previous revision: 1.152
done

Comment 6

[Dave Townsend [:mossop]]

Fixed on trunk.

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 195570 [details] [diff] [review]
patch

asking for 1.8b5 so there is consistency for what are considered valid id's
between trunk and branch.

Comment 8

[Robert Strong (they/them - no direct email)]

Checked in on MOZILLA_1_8_BRANCH

Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.144.2.10; previous revision: 1.144.2.9

Thanks for the patch!