Closed
Bug 307939
Opened 19 years ago
Closed 19 years ago
document pseudo-element code a little better
Categories
(Core :: CSS Parsing and Computation, defect, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha1
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Whiteboard: [patch])
Attachments
(1 file)
|
5.95 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Patch coming, with improved documentation and added assertions.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #195577 -
Flags: superreview?(bzbarsky)
Attachment #195577 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P4
Whiteboard: [patch]
Target Milestone: --- → mozilla1.9alpha
|
||
Comment 2•19 years ago
|
||
Comment on attachment 195577 [details] [diff] [review] patch r+sr=bzbarsky
Attachment #195577 -
Flags: superreview?(bzbarsky)
Attachment #195577 -
Flags: superreview+
Attachment #195577 -
Flags: review?(bzbarsky)
Attachment #195577 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
Fixed
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•19 years ago
|
||
So it looks like a select with no options triggers the assert in ProbePseudoStyleFor by calling it with nsCSSAnonBoxes::dummyOption as the pseudo via CreateGeneratedContentFrame (called from nsCSSFrameConstructor::AddDummyFrameToSelect). Try loading resource:///res/samples/test8.html to test. This is the current orange on balsa.
|
|
Assignee | |
Comment 5•19 years ago
|
||
I weakened the assertion to fix the orange.
You need to log in
before you can comment on or make changes to this bug.
Description
•