307980 - Security error when using evalInSandbox on http://www.ebay.com/

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Aaron Boodman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

I get a security error when trying to access window.alert through a sandbox with
evalInSandbox on ebay.com, but not on other domains.

The sandbox's codebase is set to the URL of _content. And I am accessing alert
through something like window.alert("hi") where window is sandbox.window = _content.

Here it is in code:

var box = new Components.utils.Sandbox(url);
box.window = _content;
Components.utils.evalInSandbox("window.alert('hello from: ' +
window.location.href)", box);

Reproducible: Always

Steps to Reproduce:
1. Drop the attachment into <installdir>/components/ and have Firefox autoregister
2. You should get alerts with the URL of every non-chrome window loaded
3. navigate to http://google.com, note alert
4. navigate to http://yahoo.com, note alert
5. navigate to http://ebay.com, note no alert from ebay.com (the one from
doubleclick doesn't count, we're looking for the one from the main page, not the
ad iframe). open JS console and note the security error.


Actual Results:  
Security error in JS console:

'Permission denied to get property Window.alert'

Expected Results:  
alert box with: "hello from http://www.ebay.com"

I'm putting this as Major because it prevents Greasemonkey from working properly
on all sites. Its major to me anyway.

Comment 1

[Aaron Boodman]

Attachment: testcase that demonstrates the issue

forgot the testcase attachment when i filed the bug

Comment 2

[Aaron Boodman]

Felt like I should add the entire text of the error from the console incase it's
not easy to reproduce using my testcase:

Error: [Exception... "Component returned failure code: 0x80004003
(NS_ERROR_INVALID_POINTER) [nsIDOMLocation.replace]"  nsresult: "0x80004003
(NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
file:///C:/PROGRA~1/DEERPA~3/components/ypSandboxTestCase.js :: <TOP_LEVEL> ::
line 34"  data: no]
Source File: file:///C:/PROGRA~1/DEERPA~3/components/ypSandboxTestCase.js
Line: 34

Comment 3

[Aaron Boodman]

Actually, doesn't work on yahoo either - same problem. Looks like yahoo.com also
sets it's document.domain property.

Comment 4

[Brendan Eich [:brendan]]

mrbkap, this one looks like yours, at a glance.

/be

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

It's currently impossible to do what you want in the face of setting
document.domain. To fix this, we're extending the interface of evalInSandbox to
allow you to pass a window instead of a URI, which will have all of the right
principals on it.

That would make the interesting bit in the testcase:

var sandbox = new Components.utils.Sandbox(webProgress.DOMWindow);
...

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Allow windows too

This allows you to pass a DOMWindow to the Sandbox constructor. diff -w for
review in a second.

Comment 7

[Aaron Boodman]

That solution is totally fine with me.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Allow windows too -w

Comment 9

[Brendan Eich [:brendan]]

Comment on attachment 195823 [details] [diff] [review]
Allow windows too -w

r=me if you use do_QueryWrappedNative instead of rolling your own, as you
pointed out to me!

/be

Comment 10

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 195823 [details] [diff] [review]
Allow windows too -w

>+                nsCOMPtr<nsIDOMWindow> win = do_QueryInterface(wrapper->Native());
>+                CallQueryInterface(win, &sop);

Note to self: CallQueryInterface isn't null-safe, so this needs to check |win|.

Comment 11

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 195823 [details] [diff] [review]
Allow windows too -w

sr=shaver

Comment 12

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.

Comment 13

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into MOZILLA_1_8_BRANCH.