Closed
Bug 308126
Opened 19 years ago
Closed 19 years ago
Trunk build failure in libpr0n module
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: trupesh, Assigned: pkwarren)
Details
Attachments
(1 file, 1 obsolete file)
797 bytes,
patch
|
pkwarren
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050317 Firefox/1.0.2 Build Identifier: When I build trunk on AIX, the below error occurs. "/trunk/mozilla/modules/libpr0n/encoders/png/nsPNGEncoder.cpp", line 116.14: 1540-0217 (S) "__jmpbuf" is not a member of "struct png_struct_def". gmake[3]: *** [nsPNGEncoder.o] Error 1 gmake[3]: Leaving directory `/trunk/mozilla/obj-opt/modules/libpr0n/encoders/png' gmake[2]: *** [libs] Error 2 gmake[2]: Leaving directory `/trunk/mozilla/obj-opt/modules/libpr0n/encoders' gmake[1]: *** [libs] Error 2 gmake[1]: Leaving directory `/trunk/mozilla/obj-opt/modules/libpr0n' gmake: *** [all] Error 2 Reproducible: Always
Updated•19 years ago
|
Assignee: nobody → pavlov
Component: Build Config → ImageLib
Product: Mozilla Application Suite → Core
QA Contact: build-config
Version: unspecified → Trunk
Assignee | ||
Updated•19 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
In AIX, "jmp_buf" is defined as a macro in one of the OS files. This definition is misleading the mozilla usage in nsPNGEncoder.cpp. Undefining the same resolves the issue.
Attachment #196157 -
Flags: review?
Assignee | ||
Updated•19 years ago
|
Attachment #196157 -
Flags: superreview?(tor)
Attachment #196157 -
Flags: review?(pavlov)
Attachment #196157 -
Flags: review?
Comment 2•19 years ago
|
||
Comment on attachment 196157 [details] [diff] [review] Patch r=mkaply, although should we do #ifdef jmpbuf #undef jmpbuf so it is not AIX specific?
Attachment #196157 -
Flags: review?(pavlov) → review+
Comment on attachment 196157 [details] [diff] [review] Patch I'd also prefer an "#ifdef jmpbuf" construct, with a comment explaining that AIX needs this (and what header file conflicts, for the curious).
Attachment #196157 -
Flags: superreview?(tor) → superreview-
Assignee | ||
Comment 4•19 years ago
|
||
Assignee: pavlov → pkwarren
Attachment #196157 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #196340 -
Flags: superreview?(tor)
Attachment #196340 -
Flags: review+
Attachment #196340 -
Flags: superreview?(tor) → superreview+
Assignee | ||
Comment 5•19 years ago
|
||
Fixed on trunk. Checking in nsPNGEncoder.cpp; /cvsroot/mozilla/modules/libpr0n/encoders/png/nsPNGEncoder.cpp,v <-- nsPNGEncoder.cpp new revision: 1.2; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•