308142 - Language dropdown on compose window 'Spell' icon should show language variant

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[John Wilcock]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr-FR; rv:1.7.10) Gecko/20050717 Firefox/1.0.6
Build Identifier: Thunderbird 1.5 Beta 1 (20050908)

If you install two (or more) dictionaries for variants of the same base
language, e.g. English (US) and English (UK), the dropdown shows the base
language name only, i.e. it contains English (or whatever) twice

Reproducible: Always

Steps to Reproduce:
1. Install dictionaries for two variants of the same language, e.g. install
English (UK) in addition to the English (US) shipped by default, or install both
German (Germany) and German (Switzerland)
2. Compose a message
3. Click on arrow to right of 'Spell' icon


Actual Results:  
English (and/or German) appears twice in the list.

Expected Results:  
Displayed 'English (US)' and 'English (UK)' and/or 'German (Germany)' and
'German (Switzerland)'.

This isn't the same as bug 294299, which is about labelling of i18n builds.

Comment 1

[Scott MacGregor]

that seems like a good idea. 

Comment 2

[Scott MacGregor]

Attachment: the fix

The strings in the menu now look like:

English (US)
and 
English (UK)

I also got rid of some dead code in that routine which is no longer needed.

Comment 3

[Thomas Stache]

Generally the selection of the dictionary should also be possible from the
"Options" menu in the message compose window. Is there already a bug for this?