Closed
Bug 308511
Opened 19 years ago
Closed 19 years ago
nsILDAPBERElements are incorrectly encoded
Categories
(Directory :: LDAP XPCOM SDK, defect)
Directory
LDAP XPCOM SDK
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dmosedale, Assigned: dmosedale)
Details
(Keywords: fixed1.8)
Attachments
(1 file)
|
575 bytes,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
mscott
:
approval1.8b5+
|
Details | Diff | Splinter Review |
4 byte long length fields are being generated because we're calling ber_alloc() instead of ber_alloc_t(LBER_USE_DER). Discovered by careful perusal of the source and <http://www.mozilla.org/directory/ietf-docs/draft-ietf-ldapext-ldap-c-api-05.txt>. Patch forthcoming.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #196049 -
Flags: superreview?(bienvenu)
Attachment #196049 -
Flags: review?(bienvenu)
|
||
Updated•19 years ago
|
Attachment #196049 -
Flags: superreview?(bienvenu)
Attachment #196049 -
Flags: superreview+
Attachment #196049 -
Flags: review?(bienvenu)
Attachment #196049 -
Flags: review+
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 2•19 years ago
|
||
Without this fix, LDAP controls generated by the nsILDAPControl code a while ago are invalid. Fortunately, the fix is essentially zero risk, since noone yet depends on these interfaces except for a single customer extension for Thunderbird that Ive done some work on.
Flags: blocking1.8b5?
|
||
Updated•19 years ago
|
Flags: blocking1.8b5? → blocking1.8b5+
|
|
||
Comment 3•19 years ago
|
||
Comment on attachment 196049 [details] [diff] [review] change allocation code, v1 approving for the branch. Thanks Dan.
Attachment #196049 -
Flags: approval1.8b5+
You need to log in
before you can comment on or make changes to this bug.
Description
•