Closed Bug 308580 Opened 19 years ago Closed 19 years ago

some configure.in cleanup

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

Details

Attachments

(1 file)

 
Attached patch patch v.1Splinter Review
1) Not all MOZ_XUL_APPS need or want updater.  This patch fixes this.
2) Disables View Source in minimo.
3) Removes data: protocol from minimo.
4) Removes XFT from minimo.
Comment on attachment 196096 [details] [diff] [review]
patch v.1

there is an extra '=' char in the patch:

-  NECKO_PROTOCOLS="about,data,http,file,res,jar"
+  NECKO_PROTOCOLS_DEFAULT=="about,http,file,res,jar"

i have removed it.
Comment on attachment 196096 [details] [diff] [review]
patch v.1

>-  NECKO_PROTOCOLS="about,data,http,file,res,jar"
>+  NECKO_PROTOCOLS_DEFAULT=="about,http,file,res,jar"

I think you should keep data.  It's small and useful, and we may want to
encourage its use on mobile devices.

And you certainly want == rather than =.

Other than that this looks fine.
Attachment #196096 - Flags: review+
Checking in configure.in;
/cvsroot/mozilla/configure.in,v  <--  configure.in
new revision: 1.1528; previous revision: 1.1527
done


I didn't change the data: per dbaron's request.  Also, i am using space
delimiters in the default protcols like how it is today.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: