Closed Bug 308676 Opened 19 years ago Closed 19 years ago

Serious JS GC crashes since when used with screen reader

Categories

(Firefox :: Disability Access, defect)

Product:
Firefox
Component:
Disability Access
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

Details

(Keywords: access, fixed1.8, regression)

Attachments

(2 files)

Stack trace
6.05 KB, text/plain
Details
gLastFocusedNode is not an nsCOMPtr<>
951 bytes, patch
parente
: review+
bryner
: superreview+
asa
: approval1.8b5+
Details | Diff | Splinter Review 
The regression occured Sept. 14 on branch.

The crashes are occurign about every 3rd page, seemingly randomly.
Attached file Stack trace — 

    
  
Flags: blocking1.8b5?

    
    

    
  


  
Assignee: nobody → aaronleventhal
Status: NEW → ASSIGNED

        Attachment #196189 -
        Flags: review?(parente)

    
  

        Attachment #196189 -
        Flags: superreview?(jst)

    
    

    
  
This was a regression from bug 306878.

    
    

    
  
(In reply to comment #2)
> Related to bug 308678, maybe?

No, that bug is trunk-only AFAIK.  Counterexamples welcome.

/be

    
    

    
  
No, it's bug 306878 -- almost sounded like the same bug #.

Patch is here already pending review.


    
    

    
  
Comment on attachment 196189 [details] [diff] [review]
gLastFocusedNode is not an nsCOMPtr<>

Yep. Same thing being done elsewhere in that class.

        Attachment #196189 -
        Flags: review?(parente) → review+

    
  

        Attachment #196189 -
        Flags: superreview?(jst) → superreview?(bryner)

        Attachment #196189 -
        Flags: superreview?(bryner) → superreview+

    
  

        Attachment #196189 -
        Flags: approval1.8b5?

    
  
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

    
  

        Attachment #196189 -
        Flags: approval1.8b5? → approval1.8b5+

    
  
Flags: blocking1.8b5? → blocking1.8b5+

    
  
Keywords: fixed1.8

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: