308965 - Updates radio button not checked

Status: RESOLVED DUPLICATE of bug 309015

(Firefox :: Settings UI, defect)

Description

[Dave Townsend [:mossop]]

When the user has chosen "Ask me what to do", that radio button isnt checked
when the options window is opened

Comment 1

[Dave Townsend [:mossop]]

Attachment: Patch to always set selection radio button

Since bug 303988, an element update only happens if the element doesn't already
have the value you're trying to change it to. An unintialised radiogroup has no
value. Unfortunatly since the pref for this radiogroup is boolean, that blank
is assumed to mean false. So when initialising with a false preference value,
the radiogroup is determined to be not needing an update.

This patch just makes sure that radiogroups are always initialised. Presumably
since that is ok for checkboxes then it is ok for radiogroups.

Comment 2

[Dave Townsend [:mossop]]

Fixed on trunk

Comment 3

[Asaf Romano (gone)]

Comment on attachment 196437 [details] [diff] [review]
Patch to always set selection radio button

I'm going to back this out in bug 309015.

Comment 4

[Asaf Romano (gone)]

*** This bug has been marked as a duplicate of 309015 ***