Closed
Bug 309011
Opened 19 years ago
Closed 18 years ago
Options - Tabs , items are in incorrect order
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: Peter6, Assigned: rflint)
Details
(Keywords: polish)
Attachments
(2 files, 1 obsolete file)
1.88 KB,
patch
|
Details | Diff | Splinter Review | |
2.52 KB,
patch
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050916 Firefox/1.4 ID:2005091619 Open Options window and select "tabs", lower section [] Force links that open new windows to open in 0 The same window as the link 0 A new tab [] Hide the tabbar when only one website is open [] Select new tabs opened from links [] Warn me when closing multiple tabs - item #1 and #3 are open links behaviour - item #2 and #4 are about tab behaviour should be: [] Force links that open new windows to open in 0 The same window as the link 0 A new tab [] Select new tabs opened from links [] Hide the tabbar when only one website is open [] Warn me when closing multiple tabs - item #1 and #2 are open links behaviour - item #3 and #4 are about tab behaviour In contrast to the current layout where they are mixed
Reporter | ||
Updated•19 years ago
|
Flags: blocking1.8b5?
Reporter | ||
Comment 1•19 years ago
|
||
simple fix in tabs.xul change order from: <checkbox id="hideTabBar" label="&hideTabBar.label;" accesskey="&hideTabBar.accesskey;" preference="browser.tabs.autoHide"/> <checkbox id="loadInBackground" label="&loadInBackground.label;" accesskey="&loadInBackground.accesskey;" preference="browser.tabs.loadInBackground"/> to: <checkbox id="loadInBackground" label="&loadInBackground.label;" accesskey="&loadInBackground.accesskey;" preference="browser.tabs.loadInBackground"/> <checkbox id="hideTabBar" label="&hideTabBar.label;" accesskey="&hideTabBar.accesskey;" preference="browser.tabs.autoHide"/>
Assignee | ||
Comment 2•19 years ago
|
||
Attached a patch of the proposed changes.
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•19 years ago
|
||
You know it's late when you attach a patch in the wrong format :p Corrected mistake and attached new revision.
Assignee: nobody → rflint
Attachment #196494 -
Attachment is obsolete: true
Comment 5•19 years ago
|
||
Peter, before requesting approval here, take a peek at bug 308396, which will hopefully (at part, at least) make it into 1.5 and switch the prefs to: Links that open new windows should be opened in: (*) new windows ( ) new tabs in the most recent window [ ] Always select new tabs [x] Hide the tab bar when only one web site is open [x] Warn when closing multiple tabs
Reporter | ||
Comment 6•19 years ago
|
||
Mike, I'll just leave it as is and see if Ben get's that stuff in before beta2 (planned october 5).
Assignee | ||
Comment 8•19 years ago
|
||
(In reply to comment #4) > Don't forget that the help file prefs.xhtml should also be updated. Updated help file. Just in case the UE changes in bug 308396 don't make it.
Assignee | ||
Comment 9•18 years ago
|
||
It seems a bit pointless to swap these around now that people are used to the order. If there are any objections, feel free to reopen :)
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•