309024 - Mails with vCard are marked as scam

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Frank Wein [:mcsmurf]]

When viewing a mail with a vCard in HTML View, the mail is marked as scam. The
problem is the first button in the mail labeled "View Complete Card". This form
element has no action, so
http://lxr.mozilla.org/mozilla/source/mailnews/base/resources/content/phishingDetector.js#78
returns true for isEmailScam. Maybe it should just check the action if it is != "".

Comment 1

[Ian Neal]

Attachment: Add check for View button too v0.1

View Button only shows up if JS is enabled for mailnews

This patch:
* Checks for non-empty action as well as non-addbook action

Comment 2

[[e-mail]]

Comment on attachment 196528 [details] [diff] [review]
Add check for View button too v0.1

Although, I'd prefer it if you could tweak mimevcrd.cpp to use an input
type="button" without a form...

Comment 3

[Frank Wein [:mcsmurf]]

Comment on attachment 196528 [details] [diff] [review]
Add check for View button too v0.1

Easy review
btw: Does TB not display vCards inline? Or does it need such a patch, too?

Comment 4

[David :Bienvenu]

Comment on attachment 196528 [details] [diff] [review]
Add check for View button too v0.1

tbird doesn't display the view complete card, afaik.

Comment 5

[Ian Neal]

Attachment: Unbitrotted patch v0.1a

Unbitrotted version of patch, carrying forward r/sr and requesting a= for SM1.0 and SM1.1

Comment 6

[Robert Kaiser]

Comment on attachment 209524 [details] [diff] [review]
Unbitrotted patch v0.1a

>-      isEmailScam = !/^addbook:/.test(forms[index].action);
>+      isEmailScam = forms[i].action != "" && !/^addbook:/.test(forms[index].action);


It looks to me as if that should be |forms[index]| instead of |forms[i]| (also from looking at the first patch)...

With that fix (and given that detection has been tested to work correctly with that patch), a=me for 1.1 and 1.0

Comment 7

[Ian Neal]

Attachment: Checked in patch v0.1b (Checked in trunk, branch 1.8 & branch 1.8.0)

Checking in (trunk)
phishingDetector.js;
new revision: 1.5; previous revision: 1.4
done
Checking in (branch 1.8)
phishingDetector.js;
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Checking in (branch 1.8.0)
phishingDetector.js;
new revision: 1.1.2.1.4.2; previous revision: 1.1.2.1.4.1
done

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED with a new profile using build 2006-03-26-06 of SeaMonkey trunk on Windows XP.