Closed Bug 309050 Opened 19 years ago Closed 19 years ago

Javascript error in pageInfo.js when the page contains: <iframe style="display: none;">

Categories

(Firefox :: Page Info Window, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: florian, Assigned: florian)

References

()

Details

(Keywords: fixed1.8)

Attachments

(1 file)

With a page containing "<iframe style="display: none;">" I get those errors in
the javascript console when I open the Page Info window:

Firefox 1.0.4 :
Error: elem.ownerDocument.defaultView has no properties
Source File: chrome://browser/content/pageInfo.js
Line: 477

SeaMonkey (20050904):
Error: elem.ownerDocument.defaultView.getComputedStyle(elem, "") has no properties
Source File: chrome://navigator/content/pageInfo.js
Line: 524

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050918 Firefox/1.6a1 :
Error: elem.ownerDocument.defaultView.getComputedStyle(elem, "") has no properties
Source File: chrome://browser/content/pageInfo.js
Line: 487
Attached patch patch v1Splinter Review
Comment on attachment 196550 [details] [diff] [review]
patch v1

excellent, thanks.
Attachment #196550 - Flags: review+
Attachment #196550 - Flags: superreview+
Tiny nitpicky nit: camelCaps is standard in at least /browser, so it should be
"computedStyle".
OS: Linux → All
Hardware: PC → All
Comment on attachment 196550 [details] [diff] [review]
patch v1

fix checked in trunk by bzbarsky
Attachment #196550 - Flags: approval1.8b5?
Can you clarify on why this is needed for 1.8b5? What does it break?
(In reply to comment #5)
> Can you clarify on why this is needed for 1.8b5? 
It isn't absolutely needed but it's a safe patch.

> What does it break?
The bug breaks the Page Info window (Forms, Links and Media tabs) on pages
containing <iframe style="display: none;">.
For example, on the homepage of http://www.clubic.com (a big french site)
Flags: blocking1.8b5+
Comment on attachment 196550 [details] [diff] [review]
patch v1

Per bug meeting - approved for 1.8b5 branch.
Attachment #196550 - Flags: approval1.8b5? → approval1.8b5+
fix checked in the 1.8 branch by db48x
Status: NEW → RESOLVED
Closed: 19 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: