309306 - Drag and drop of a file onto the Extension Manager works inconsistently and can cause a crash [@ JS_GetPrivate][@ nsWindow::OnDragMotionEvent]

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

This is essentially the same as bug 269568 except it is for the Extension
Manager component. Here is the talkback incident id though talkback is seriously
backed up atm.
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=TB9541359X

To reproduce, try DnD of a local file onto the Extension or Theme Manager with
Linux (tonight I am using slackware 10.1 and tested both gnome and kde - I have
also reproduced on other distros)... when I did this repeatedly Firefox crashed,
if I wait around 15 to 30 seconds it will sometimes install the extension. This
doesn't appear to affect the browser content window which is probably due to not
trying to validate the DnD data before the drop occurs as noted in bug 269568.

The following message was reported repeatedly to the console even well after the
DnD operation had been completed (also explained in bug 269568.
(Gecko:3505): Gtk-CRITICAL **: gtk_drag_get_data: assertion `GTK_IS_WIDGET
(widget)' failed

I believe the best option would be to #ifndef XP_UNIX the DnD validation part of
the EM code for drag enter which will make this behave in the same manner as the
the majority of the rest of the ui does for all OS's except this would just be
for UNIX. Another option would be to change the EM code to not validate the DnD
code for drag enter for all OS's but I think that would be overkill though it
would make the behavior more consistent with the rest of the ui though it would
be incorrect behavior.

Wallpaper patch coming up.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: wallpaper patch

Wallpaper for just the EM to allow DnD install of extensions and themes on
Linux

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 196779 [details] [diff] [review]
wallpaper patch

meh!
this will break dnd for Mac too, too early in the morning yet.

Comment 3

[Robert Strong (they/them - no direct email)]

I didn't realize that UNIX included Mac's. From what I recall Mac OS X doesn't
provide DnD feedback until the drop occurs so the behavior should be the same
but I may be wrong with this... I'll resubmit an updated patch.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: use MOZ_WIDGET_GTK2

The only reports of this happening are with GTK2 so I changed it to use
MOZ_WIDGET_GTK2 instead of XP_UNIX. Comparing the DnD code for GTK and GTK2 it
is entirely possible that GTK is not affected.

Comment 5

[Robert Strong (they/them - no direct email)]

I was testing extensions with a non-patched beta 1 build today and ran into this
when DnD'ng onto the content window and passed over the EM ui before the drop.
The following ended up in the urlbar and when I exited a crash occurred. :/

keyword:%E6%A5%A6%E6%95%AC%E2%BC%BA%E6%BD%B2%E7%91%AF%E4%90%AF%E7%8D%A5
%E7%91%AB%E7%81%AF%E6%9C%AF%E6%BD%AF%E6%B1%A7%E2%B5%A5%E6%BD%B4%E6%B1%AF
%E6%85%A2%E2%B9%B2%E7%81%B8%E2%B9%A9%E6%A5%BA%E2%B9%B0%E7%81%B8%E0%B5%A9

Mike, is there anyway this can make it into 1.5?

Comment 6

[Robert Strong (they/them - no direct email)]

Checked in on trunk

Checking in mozilla/toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <-- 
extensions.js
new revision: 1.78; previous revision: 1.77

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 196813 [details] [diff] [review]
use MOZ_WIDGET_GTK2

Requesting 1.8b5.

This patch wallpapers over bug 269568 which affects DnD with GTK2 builds by
preventing the installation of extensions / themes using DnD and will often
result in a crash. I have been using the patch successfully for several weeks
and the reporter of bug 269568 has also confirmed that the patch fixes this bug
for him.

Comment 8

[Mike Schroepfer]

Comment on attachment 196813 [details] [diff] [review]
use MOZ_WIDGET_GTK2

Approved per 9/26 bug triage meeting.

Comment 9

[Robert Strong (they/them - no direct email)]

Checked in on MOZILLA_1_8_BRANCH

Checking in mozilla/toolkit/mozapps/extensions/content/extensions.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/extensions.js,v  <-- 
extensions.js
new revision: 1.72.2.6; previous revision: 1.72.2.5