30937 - crash when imap server goes down.

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

I noticed this a bunch today, because tintin kept going down.

here's the fix for the crash:

Index: nsImapProtocol.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/imap/src/nsImapProtocol.cpp,v
retrieving revision 1.232
diff -r1.232 nsImapProtocol.cpp
831c831
<   if (NS_SUCCEEDED(rv) && TestFlag(IMAP_CONNECTION_IS_OPEN))
---
>   if (NS_SUCCEEDED(rv) && TestFlag(IMAP_CONNECTION_IS_OPEN) && m_ouputStream)

basically, the m_outputStream is not there, and we try to send
"logout" over it.

Comment 1

[(not reading, please use [e-mail] instead)]

whoops, I spelled outputStream wrong in that patch.

marking beta1, I keep seeing this and it hurts my own dogfood efforts.

Comment 2

[Phil Peterson]

[PDT+] w/b minus on 3/8. No big changes, please. Defensive null pointer test 
only.

Comment 3

[(not reading, please use [e-mail] instead)]

fixed.

Comment 4

[Scott MacGregor]

*** Bug 30807 has been marked as a duplicate of this bug. ***

Comment 5

[fenella]

Seth,
To re-test this bug, can I just un-plug the network plug or I have to try to
physically turn off a test sever?
thanks for advise.

Comment 6

[fenella]

Seth, I am unable to bring down the tin-tin imap server to re-test this bug. So
I used the imap server in the lab.
steps:
1. Create an imap account parp30 using the parp.mcom.com server
2. Bring up Messenger and load the messages from the server using the parp30
account.
3. View the message, no problem
4. Now stop the parp.mcom.com server
5. Back to Messenger, and click on a message, it does not crash applicaction any
more.

Comment 7

[(not reading, please use [e-mail] instead)]

try this:

connect to an imap server.  read mail.

unconnect your ethernet cable.

hit get new messages.

see http://bugzilla.mozilla.org/show_bug.cgi?id=30807 for another way to 
reproduce