Closed
Bug 309379
Opened 19 years ago
Closed 19 years ago
update answers.com plug-in
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: rebron, Assigned: bugs)
References
Details
(Keywords: fixed1.8, late-l10n, Whiteboard: [needs review bsmedberg])
Attachments
(1 file)
1.05 KB,
patch
|
benjamin
:
review+
mscott
:
approval1.8b5+
|
Details | Diff | Splinter Review |
From the Answers people, need to update the search url. Assuming you're looking up the word topic Method #1: http://www.answers.com/main/ntquery?s=topic&gwp=13 or http://www.answers.com/main/ntquery?gwp=13&s=topic Method #2: http://www.answers.com/topic?gwp=13
Reporter | ||
Updated•19 years ago
|
Flags: blocking1.8b5?
Comment 1•19 years ago
|
||
*** Bug 308122 has been marked as a duplicate of this bug. ***
Comment 2•19 years ago
|
||
rebron: did you really mean to assign this to Ben's account with the realname "Ben Goodger (Do not assign bugs to this!)"?
Assignee | ||
Comment 3•19 years ago
|
||
Attachment #196840 -
Flags: review?(benjamin)
Assignee | ||
Comment 4•19 years ago
|
||
Yes, I told him to. Sorry for the confusion.
Comment 5•19 years ago
|
||
Do we need this for the copies of this plugin in l10n, too? Probably the change of the action, but the tracking code as well?
Reporter | ||
Comment 6•19 years ago
|
||
Yes for locales as well.
Comment 7•19 years ago
|
||
Setting late-l10n as per rebron's comment, I may be tempted to just land the appropriate changes on the branch myself, as this is just technical stuff. I'll assemble a list of affected locales and CC their owners once this has approval.
Keywords: late-l10n
Comment 8•19 years ago
|
||
Comment on attachment 196840 [details] [diff] [review] update the answers.com plugin to include tracking code. I wonder if + action="http://www.answers.com/main/ntquery and + <input name="s" user> + <input name="gwp" value="13"> wouldn't be the more common way to fix this.
Assignee | ||
Comment 9•19 years ago
|
||
Axel: probably. Last time we did one of these updates to the answers plugin Benjamin said this wasn't late-l10n since only en-US used answers.com...
Comment 10•19 years ago
|
||
That... turns out not to be the case. mn has been using it long enough that they didn't get the ISO-8859-1 to UTF-8 queryCharset change; es-AR, el, and da didn't get the Dictionary to Answers.com name change.
Assignee | ||
Comment 11•19 years ago
|
||
OK.
Updated•19 years ago
|
Flags: blocking1.8b5? → blocking1.8b5+
Updated•19 years ago
|
Whiteboard: [needs review bsmedberg]
Updated•19 years ago
|
Attachment #196840 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 13•19 years ago
|
||
Comment on attachment 196840 [details] [diff] [review] update the answers.com plugin to include tracking code. requesting approval for checkin
Attachment #196840 -
Flags: approval1.8b5?
Updated•19 years ago
|
Attachment #196840 -
Flags: approval1.8b5? → approval1.8b5+
Assignee | ||
Comment 14•19 years ago
|
||
fixed branch and trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•