309834 - useless code in wallet source

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050815 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050815 Firefox/1.0.6

Some code around line 2310 in extensions/wallet/src/singsign.cpp sets data2 to
the same value as data:

data2 = NS_STATIC_CAST(si_SignonDataStruct*, signonData->ElementAt(j));

data has been set to this very exact value (considering the branch we are in)
and can be used in this block instead of data2

Reproducible: Always

Steps to Reproduce:

Comment 1

[[e-mail]]

Attachment: Fix useless duplicate data

Comment 2

[PikeUK]

You'll need to seek review from someone if you want your code to be checked-in.

->MAS: Password Manager (Hope that's the right place)

Comment 3

[Boris Zbarsky [:bzbarsky]]

Checked in on trunk.  Samuel, thanks for the patch!  I'm sorry it took so long to get checked in; the problem is that generally reviewers only see patches they've been asked for review for.  See http://www.mozilla.org/hacking/life-cycle.html for more info.